Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/express-serve-static-core to v5 #2232

Closed

Conversation

backstage-goalie[bot]
Copy link
Contributor

@backstage-goalie backstage-goalie bot commented Dec 20, 2024

This PR contains the following updates:

Package Type Update Change Pending
@types/express-serve-static-core (source) devDependencies major ^4.17.5 -> ^5.0.0 5.0.3
@types/express-serve-static-core (source) devDependencies major ^4.17.5 -> ^5.0.0 5.0.3
@types/express-serve-static-core (source) devDependencies major ^4.17.5 -> ^5.0.0 5.0.3
@types/express-serve-static-core (source) devDependencies major ^4.17.5 -> ^5.0.0 5.0.3

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@backstage-goalie
Copy link
Contributor Author

Changed Packages

Package Name Package Path Changeset Bump Current Version
backend workspaces/3scale/packages/backend none v0.0.1

@awanlin
Copy link
Contributor

awanlin commented Dec 20, 2024

Hi, for those tagged on this PR can you give this a quick look, please? It's a major version change just want to be sure. Thanks!

@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch 5 times, most recently from 87b0a1c to 2fa41c4 Compare December 23, 2024 16:26
@backstage-goalie backstage-goalie bot changed the title chore(deps): update dependency @types/express-serve-static-core to v5 Update dependency @types/express-serve-static-core to v5 Dec 23, 2024
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch 4 times, most recently from bcc6a96 to fd65ee3 Compare December 23, 2024 23:22
@backstage-goalie backstage-goalie bot changed the title Update dependency @types/express-serve-static-core to v5 chore(deps): update dependency @types/express-serve-static-core to v5 Dec 23, 2024
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch 2 times, most recently from 1f7b012 to 54236ba Compare December 24, 2024 01:49
@backstage-goalie backstage-goalie bot changed the title chore(deps): update dependency @types/express-serve-static-core to v5 Update dependency @types/express-serve-static-core to v5 Dec 24, 2024
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch from 54236ba to 8381136 Compare December 24, 2024 14:22
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch 3 times, most recently from 06d6a71 to 0f285b6 Compare December 25, 2024 17:19
@backstage-goalie backstage-goalie bot changed the title Update dependency @types/express-serve-static-core to v5 chore(deps): update dependency @types/express-serve-static-core to v5 Dec 25, 2024
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch 7 times, most recently from cdb3baa to d9d380d Compare December 29, 2024 21:18
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch 2 times, most recently from 2eae084 to c6fed52 Compare January 2, 2025 11:19
@04kash
Copy link
Member

04kash commented Jan 2, 2025

Since this is a type library, as long as the CI passes everything should be fine

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Jan 2, 2025

@04kash I agree. On the otherside I would expect that this type is matching express v5. And as long backstage is using express v4 I don't expect that we should update this now and instead just close this PR anyway.

@04kash @awanlin And while checking this: I don't understand why this type is needed at all!

I guess it's a copy paste issue. At least a new backstage scaffold project doesn't need @types/express or @types/express-serve-static-core. And I just found one import of this package in the RBAC-Backend.

I like to create a PR that removes this dependency and aligns all the workspaces/*/packages/{app,backend}/package.json, when this is fine for you.

--
edit: You can find the first PRs below. I created multiple PRs to get it easier to test and review them:

Signed-off-by: Renovate Bot <bot@renovateapp.com>
@backstage-goalie backstage-goalie bot force-pushed the renovate/express-serve-static-core-5.x branch from c6fed52 to 38a2d8a Compare January 2, 2025 22:16
@christoph-jerolimov
Copy link
Member

First 6 PRs are created and ready for review; 13 more will come over the next days... 🤯

I hope it's fine that I close this PR now, otherwise the bot will push and build all these plugins again and again...

If you don't agree please let me know or reopen this PR.

@christoph-jerolimov christoph-jerolimov deleted the renovate/express-serve-static-core-5.x branch January 2, 2025 23:49
@backstage-goalie
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@04kash
Copy link
Member

04kash commented Jan 3, 2025

First 6 PRs are created and ready for review; 13 more will come over the next days... 🤯

Thanks @christoph-jerolimov, if you need any help with the remaining PRs lmk!

@awanlin
Copy link
Contributor

awanlin commented Jan 3, 2025

Hi @christoph-jerolimov @04kash, agree with closing this and working to remove the unused dependencies in the various impacted workspaces. Thanks for starting this @christoph-jerolimov.

In future could we perhaps log an issue for this so that way we can have a bit of discussion and engage the community to help? Though this is worthwhile to do there are a few other items that have higher priority that we could use both of your help with:

Does that make sense?

@04kash
Copy link
Member

04kash commented Jan 3, 2025

Yup that sounds good, I can start taking a look at some of these next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants