-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @types/express-serve-static-core to v5 #2232
Conversation
Changed Packages
|
Hi, for those tagged on this PR can you give this a quick look, please? It's a major version change just want to be sure. Thanks! |
87b0a1c
to
2fa41c4
Compare
bcc6a96
to
fd65ee3
Compare
1f7b012
to
54236ba
Compare
54236ba
to
8381136
Compare
06d6a71
to
0f285b6
Compare
cdb3baa
to
d9d380d
Compare
2eae084
to
c6fed52
Compare
Since this is a type library, as long as the CI passes everything should be fine |
@04kash I agree. On the otherside I would expect that this type is matching express v5. And as long backstage is using express v4 I don't expect that we should update this now and instead just close this PR anyway. @04kash @awanlin And while checking this: I don't understand why this type is needed at all! I guess it's a copy paste issue. At least a new backstage scaffold project doesn't need I like to create a PR that removes this dependency and aligns all the -- |
Signed-off-by: Renovate Bot <bot@renovateapp.com>
c6fed52
to
38a2d8a
Compare
First 6 PRs are created and ready for review; 13 more will come over the next days... 🤯 I hope it's fine that I close this PR now, otherwise the bot will push and build all these plugins again and again... If you don't agree please let me know or reopen this PR. |
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
Thanks @christoph-jerolimov, if you need any help with the remaining PRs lmk! |
Hi @christoph-jerolimov @04kash, agree with closing this and working to remove the unused dependencies in the various impacted workspaces. Thanks for starting this @christoph-jerolimov. In future could we perhaps log an issue for this so that way we can have a bit of discussion and engage the community to help? Though this is worthwhile to do there are a few other items that have higher priority that we could use both of your help with:
Does that make sense? |
Yup that sounds good, I can start taking a look at some of these next week |
This PR contains the following updates:
^4.17.5
->^5.0.0
5.0.3
^4.17.5
->^5.0.0
5.0.3
^4.17.5
->^5.0.0
5.0.3
^4.17.5
->^5.0.0
5.0.3
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.