Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin(jenkins): remove support for legacy backend system #2589

Merged
merged 2 commits into from
Feb 4, 2025
Merged

plugin(jenkins): remove support for legacy backend system #2589

merged 2 commits into from
Feb 4, 2025

Conversation

04kash
Copy link
Member

@04kash 04kash commented Jan 27, 2025

Hey, I just made a Pull Request!

  • Removed usages and references of @backstage/backend-common
  • Removed support for legacy backend system

Related to: #1176

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@04kash 04kash requested review from backstage-service and a team as code owners January 27, 2025 21:14
@04kash 04kash requested a review from nickboldt January 27, 2025 21:14
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Jan 27, 2025 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-jenkins-backend workspaces/jenkins/plugins/jenkins-backend minor v0.10.0

@04kash 04kash force-pushed the jenkins/remove-backend-common branch from f0de080 to 1f87481 Compare January 27, 2025 21:22
kurtaking
kurtaking approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@kurtaking kurtaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to help review these? The changes look good to me.

My only recommendation would be to be a bit more verbose in the changeset about how the router props have changed, but an argument could be made that it's part of the new backend migration.

awanlin
awanlin requested changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @04kash, just need some updated to the README 👍

@04kash
plugin(jenkins): remove support for legacy backend system
65f19ff 
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
@04kash 04kash force-pushed the jenkins/remove-backend-common branch from 1f87481 to 65f19ff Compare February 2, 2025 18:44
@04kash
README fixes
eab66f8 
Signed-off-by: Kashish Mittal <kmittal@redhat.com>
@04kash 04kash requested a review from awanlin February 3, 2025 19:59
awanlin
awanlin approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@awanlin awanlin merged commit 29de0c4 into backstage:main Feb 4, 2025
12 checks passed
harmenbrinkmanTRIMM pushed a commit to harmenbrinkmanTRIMM/community-plugins that referenced this pull request Feb 19, 2025
@04kash @harmenbrinkmanTRIMM
plugin(jenkins): remove support for legacy backend system (backstage#…
ff6d5c0 
…2589)

* plugin(jenkins): remove support for legacy backend system

Signed-off-by: Kashish Mittal <kmittal@redhat.com>

* README fixes

Signed-off-by: Kashish Mittal <kmittal@redhat.com>

---------

Signed-off-by: Kashish Mittal <kmittal@redhat.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtaking kurtaking kurtaking approved these changes

@awanlin awanlin awanlin approved these changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

@nickboldt nickboldt Awaiting requested review from nickboldt nickboldt is a code owner automatically assigned from backstage/community-plugins-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@04kash @kurtaking @awanlin