workspaces: add Node.js 22 to engines field across all workspaces

[BethGriggs]

Hey, I just made a Pull Request!

Manually updates the "engines" field of all workspace package.json files
to include Node.js 22. This intentionally replaces part of the generated
rennovate PR which attempted to replace rather than add Node.js 22 to the
engines field.

Note that this is only updates the workspace package.json - therefore it
should not impact end users installing plugins.

Refs: #2403

✔️ Checklist

• A changeset describing the change and affected packages. (more info)
• Added or updated documentation
• Tests for new functionality and regression tests for bug fixes
• Screenshots attached (for UI changes)
• All your commits have a Signed-off-by line in the message. (more info)

[BethGriggs]

Most of the failures look to be related to failed canvas builds.

[schultzp2020]

Should we remove node 18 from the "engines" field because its end of life is on April 30th? Personally I'm in favor of it.

[BethGriggs]

@schultzp2020, see our discussion on https://github.com/backstage/community-plugins/pull/2403/files#r2034107459.

IMO the engines fields should be communication from the workspace/plugin owner about compatibility rather than a blanket change applied across the repository.

I strongly think we should leave it to workspace/plugin owners to decide. Dropping a version from engines can be breaking change if anyone is installing with enginesStrict:true. This was the rationale for this additive approach.

[schultzp2020]

@schultzp2020, see our discussion on https://github.com/backstage/community-plugins/pull/2403/files#r2034107459.

IMO the engines fields should be communication from the workspace/plugin owner about compatibility rather than a blanket change applied across the repository.

I strongly think we should leave it to workspace/plugin owners to decide. Dropping a version from engines can be breaking change if anyone is installing with enginesStrict:true. This was the rationale for this additive approach.

@BethGriggs Adopters are likely to face issues regardless, since backstage/backstage enforces stricter versioning with 20 | 22. In my opinion, it's best to follow the core repository’s lead, straying from it will only make long-term maintenance more difficult. We’re going to encounter the same challenges when React 17 and React Router 6 are deprecated. In fact, we’re already seeing this with React 16, as most workspaces haven’t deprecated it yet, even though the core repository dropped support two releases ago. At some point the community plugin maintainers need to step in and overrule when it comes to deprecated/end of life features.

[BethGriggs]

Plugin consumers may still be using earlier versions of Backstage, though.

At the very least I think we should hold off on forced removal of Node.js 18 from within the workspaces until it is officially EOL at the end of the month. Simultaneously we can open an issue to socialise so workspace owners have time to consider impact on their consumers and migrate anything if necessary.

[BethGriggs]

Adopting canvas@v3 should fix the failures across all those workspaces. The only breaking change in v3 appears to be dropping support for Node.js 16 so it should be safe to adopt in all workspaces.

I tried triggering the update via #392 but it hasn't been generated yet.

[BethGriggs]

Requires #3563 for CI to pass on workspaces failing with canvas build issues.

[awanlin]

Hi @BethGriggs, do we need Canvas anymore? backstage/backstage#27287. This was released in 1.33.0. Sorry, have not looked at the exact code in this repo yet.

[BethGriggs]

@awanlin I'd be quite happy if that's the case, but I think I saw some direct usage. I'll take a closer look and see.

[BethGriggs]

It does looks like only one or two plugins actually use it, I'll work on a PR to remove it where we can as it's also already listed in some of the knip reports.

[awanlin]

Thanks for running with this @BethGriggs, was the next on my pile once we got all the backend-common usages removed. Left a few comments.

Once thing I had been thinking about this is that it would be great to have a codemod for this as we'll need to do this each year.

[awanlin]

Awesome, thanks @BethGriggs 🚀

[awanlin]

Shoot, I really need to remember to check the CI before approving. This CI error looks like it will be a fun one 🤔

[BethGriggs]

I reverted the Kiali change as it was already set to 22 in the engines. CI on this PR is passing now.

[04kash]

I think we should also update the package.json template in repo-tools so that newly created workspaces have Node.js 22 in their engine fields

[backstage-goalie]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@backstage-community/cli	workspaces/repo-tools/packages/cli	none	v0.0.3

[04kash]

lgtm!