Skip to content

workspaces: add Node.js 22 to engines field across all workspaces #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 17, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
matrix:
workspace: ${{ fromJSON(needs.find-changed-workspaces.outputs.workspaces) }}
node-version: [18.x, 20.x]
node-version: [20.x, 22.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove 18.x?

Copy link
Collaborator Author

@BethGriggs BethGriggs Apr 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in the CI matrix, Node.js 20 and 22 are the only supported versions supported by the Backstage framework and we agreed it made sense to align with the versions they test -https://github.com/backstage/backstage/blob/master/.github/workflows/ci.yml#L22

Note this doesn't impact what workspaces/plugins can claim support for - just what is tested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Official Backstage Node policy for reference: https://backstage.io/docs/overview/versioning-policy#nodejs-releases

fail-fast: false
defaults:
run:
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"repository": "git@github.com:backstage/community-plugins.git",
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"create-workspace": "community-cli workspace create",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/3scale/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/acr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/adr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/airbrake/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/allure/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/amplication/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/analytics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/announcements/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/apache-airflow/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/apollo-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/azure-devops/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/azure-resources/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/azure-sites/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/azure-storage-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/badges/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/bazaar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/bitrise/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/blackduck/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/cicd-statistics/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/cloudbuild/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/code-climate/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/code-coverage/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/codescene/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/confluence/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/copilot/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/cost-insights/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/dynatrace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/entity-feedback/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/entity-validation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/explore/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/feedback/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include @backstage-community/plugin-feedback-backend --include @backstage-community/plugin-feedback --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/firehydrant/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/fossa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/gcalendar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/gcp-projects/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/git-release-manager/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/github-actions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/github-deployments/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/github-discussions/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -v -i run start",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/github-issues/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/github-pull-requests-board/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "18 || 20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
2 changes: 1 addition & 1 deletion workspaces/gitops-profiles/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "1.0.0",
"private": true,
"engines": {
"node": "18 || 20"
"node": "20 || 22"
},
"scripts": {
"tsc": "tsc",
Expand Down
Loading