fix: consider decimal rating for Firefox extension (#11068)

cyb3rko · web-flow · commit d1ece32c1119 · 2025-05-11T10:49:02.000Z
diff --git a/services/amo/amo-rating.service.js b/services/amo/amo-rating.service.js
@@ -27,10 +27,12 @@ export default class AmoRating extends BaseAmoService {
   static _cacheLength = 7200
 
   static render({ format, rating }) {
-    rating = Math.round(rating)
     return {
       label: format,
-      message: format === 'stars' ? starRating(rating) : `${rating}/5`,
+      message:
+        format === 'stars'
+          ? starRating(rating)
+          : `${Math.round(rating * 10) / 10}/5`,
       color: floorCountColor(rating, 2, 3, 4),
     }
   }
diff --git a/services/amo/amo-rating.tester.js b/services/amo/amo-rating.tester.js
@@ -7,7 +7,7 @@ t.create('Rating')
   .get('/rating/IndieGala-Helper.json')
   .expectBadge({
     label: 'rating',
-    message: Joi.string().regex(/^\d\/\d$/),
+    message: Joi.string().regex(/^\d(\.\d)?\/\d$/),
   })
 
 t.create('Stars')

Original file line number	Diff line number	Diff line change
`@@ -27,10 +27,12 @@ export default class AmoRating extends BaseAmoService {`
`27`	`27`	`static _cacheLength = 7200`
`28`	`28`
`29`	`29`	`static render({ format, rating }) {`
`30`		`- rating = Math.round(rating)`
`31`	`30`	`return {`
`32`	`31`	`label: format,`
`33`		- message: format === 'stars' ? starRating(rating) : `${rating}/5`,
	`32`	`+ message:`
	`33`	`+ format === 'stars'`
	`34`	`+ ? starRating(rating)`
	`35`	+ : `${Math.round(rating * 10) / 10}/5`,
`34`	`36`	`color: floorCountColor(rating, 2, 3, 4),`
`35`	`37`	`}`
`36`	`38`	`}`