[sourceforge] add repo param to last commit service #10935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some sourceforge projects have multiple repositories, so we need to specify the repository to use for the last commit service.
jNullj
force-pushed
the
jNullj/issue10921
branch
from
b96249f to
18bd3a0
Compare
jNullj
force-pushed
the
jNullj/issue10921
branch
from
18bd3a0 to
445edcf
Compare
|
Tested locally and it seems to work |
|
The change is ready for review, but i just realized this problem is not specific to this badge, its relevant to multiple sourceforge badges. 😅 |
|
🚀 Updated review app: https://pr-10935-badges-shields.fly.dev |
|
Thanks. Yes. This same problem will apply to (for example) the SourceForge Commit Count badge. Although I think a lot of the sourceforge badges won't need any changes because they are project-level rather than repo-level. Anyway, this PR fixes a thing that was broken. Further fixes can come in another PR. |
chris48s
approved these changes
Mar 9, 2025
jNullj
added a commit
to jNullj/shields-fun-fork
that referenced
this pull request
Mar 15, 2025
follow-up to badges#10935 sourceforge commit count also requires the new repo param for some projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some sourceforge projects have multiple repositories, so we need to
specify the repository to use for the last commit service.
should be backward compitable with redirect
fixes #10921