-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: add new badges for new [ansible] collection APIs #10938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51462f9
to
0200661
Compare
On your tests: You can call any shields badge URL with a .json extension to request a JSON response instead of SVG. So for example:
In the service tests we test the JSON response because it is easier to make assertions about the JSON response than the SVG response. The logic for rendering that object into a SVG image is tested separately. At the moment you're requesting a SVG response then trying to make assertions about it as if it were a JSON object. Hence they're all failing with Error: |
Ahhh thank you, will update those test endpoints to use Now, why are the checks in the PR all passing, shouldn't something fail and flag that these tests are failing and need to be corrected? |
🚀 Updated review app: https://pr-10938-badges-shields.fly.dev |
We hit live APIs under test, so a full service test run is slow and contains some tests that can be flaky. For this reason, we run all the core tests automatically but you have to opt in to running a subset of service tests: |
Thank you, apologies for missing that! |
0a7130e
to
5f20967
Compare
5f20967
to
4b41ea1
Compare
🚀 Updated review app: https://pr-10938-badges-shields.fly.dev |
No description provided.