Skip to content

Refactor named logo handling into badge-maker #10955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Refactor named logo handling into badge-maker #10955

wants to merge 6 commits into from

Conversation

jNullj
Copy link
Member

@jNullj jNullj commented Mar 15, 2025 •
edited
Loading

  • moved /lib helper files into badge-maker as they seem more relevant there now.
  • handle named logo size and base64 conversion in badge-maker

TODO

  • update dependencies (make named logo optional)
  • update tests to fit the refactor
  • expose named logo/named logo color params in badge maker

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2025 •
edited
Loading

Warnings
⚠️

This PR modified package.json, but not package-lock.json - Perhaps you need to run npm install?
Messages
📖 ✨ Thanks for your contribution to Shields, @jNullj!

Generated by 🚫 dangerJS against 9b7ad5a

@jNullj jNullj added core Server, BaseService, GitHub auth, Shared helpers dependencies Related to dependency updates npm-package Badge generation and badge templates labels Mar 15, 2025
@jNullj jNullj added the developer-experience Dev tooling, test framework, and CI label Mar 15, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Mar 15, 2025 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@actions/core@1.11.1 environment, filesystem Transitive: network, shell, unsafe +6 1.56 MB thboop
npm/@actions/github@6.0.0 environment, filesystem Transitive: network, unsafe +21 13 MB thboop

🚮 Removed packages: npm/eslint-plugin-chai-friendly@1.0.1, npm/eslint-plugin-cypress@4.2.0, npm/eslint-plugin-icedfrisby@0.2.0, npm/eslint-plugin-import@2.31.0, npm/eslint-plugin-jsdoc@50.6.6

View full report↗︎

@LitoMore LitoMore mentioned this pull request Apr 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth, Shared helpers dependencies Related to dependency updates developer-experience Dev tooling, test framework, and CI npm-package Badge generation and badge templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jNullj