Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix record to xml conversion missing namespace when namespace annotation defined in field level and annotation lookup logic #27

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

prakanth97
Copy link
Contributor

Purpose

Fixes: #6694

Examples

Checklist

  • Linked to an issue
  • Updated the changelog
  • Added tests
  • Updated the spec
  • Checked native-image compatibility

@prakanth97 prakanth97 requested a review from hasithaa as a code owner July 4, 2024 12:35
@prakanth97 prakanth97 requested a review from ayeshLK July 4, 2024 17:59
@prakanth97 prakanth97 changed the title Fix record to xml conversion missing namespace when namespace annotation defined in field level Fix record to xml conversion missing namespace when namespace annotation defined in field level and annotation lookup logic Jul 4, 2024
Soap1 val = {
htngReplyTo: {
Address: {
code: 40000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually, this is a URI, not a physical address. :) But the example is ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added it to check the nested case.

@prakanth97 prakanth97 merged commit a15b675 into ballerina-platform:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generated xml from toXml() missing namespaces
3 participants