Fix namespaces related issues for toXml API in data.xmldata module
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SasinduDilshara
force-pushed
the
fix_toxml_issues
branch
from
88bdf36 to
01c797c
Compare
chiranSachintha
requested changes
Feb 21, 2025
native/src/main/java/io/ballerina/lib/data/xmldata/utils/ToXmlUtils.java
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/xmldata/utils/DataUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/xmldata/utils/DataUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/xmldata/utils/DataUtils.java
Outdated
Show resolved
Hide resolved
native/src/main/java/io/ballerina/lib/data/xmldata/utils/DataUtils.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=========================================
Coverage 85.31% 85.31%
- Complexity 906 911 +5
=========================================
Files 31 31
Lines 3752 3794 +42
Branches 756 767 +11
=========================================
+ Hits 3201 3237 +36
- Misses 332 338 +6
Partials 219 219 ☔ View full report in Codecov by Sentry. |
|
There are some Codecov warnings, please check them as well. |
Those are not what we intened to use via the xsd tool |
chiranSachintha
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix namespaces related issues for
toXmlAPI indata.xmldatamoduleFixes: ballerina-platform/ballerina-library#7402
Fixes: ballerina-platform/ballerina-library#7423
Fixes: ballerina-platform/ballerina-library#7441