Add namespace awareness for validating xml against xsd files #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
============================================
- Coverage 85.92% 85.32% -0.61%
- Complexity 800 911 +111
============================================
Files 25 31 +6
Lines 3432 3795 +363
Branches 685 767 +82
============================================
+ Hits 2949 3238 +289
- Misses 303 338 +35
- Partials 180 219 +39 ☔ View full report in Codecov by Sentry. |
gimantha
reviewed
Feb 26, 2025
| dbFactory.setIgnoringComments(true); // Ignore comments in the XML | ||
| dbFactory.setIgnoringElementContentWhitespace(true); // Ignore white spaces in the XML |
There was a problem hiding this comment.
We may need to provide a configuration to override the removal of leading and trailing whitespaces
There was a problem hiding this comment.
I will revert that
gimantha
previously approved these changes
Feb 26, 2025
gimantha
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add namespace awareness for validating xml against xsd files
Fixes: ballerina-platform/ballerina-library#7643
Examples
Checklist