Migrate to Java 21 #1248
Merged
Migrate to Java 21 #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warunalakshitha
requested review from
ThisaruGuruge,
DimuthuMadushan,
MohamedSabthar and
shafreenAnfar
as code owners
warunalakshitha
force-pushed
the
java21
branch
3 times, most recently
from
96aeb3c to
91cd206
Compare
warunalakshitha
force-pushed
the
java21
branch
from
91cd206 to
a7c88d5
Compare
|
warunalakshitha
commented
Oct 11, 2024
| private static void invokeAsyncCall(UdpService udpService, DatagramPacket datagramPacket, Channel channel, | ||
| String methodName, Object[] params) { | ||
| Thread.startVirtualThread(() -> { | ||
| BObject service = udpService.getService(); |
There was a problem hiding this comment.
Since Dispatcher is call from non ballerina thread (UdpListenerHandler netty thread) We should not block any calls. So we have to use virtual thread
warunalakshitha
commented
Oct 11, 2024
| client.addNativeData(Constants.CONNECTIONLESS_CLIENT, udpClient); | ||
|
|
||
| return null; | ||
| return env.yieldAndRun(() -> { |
There was a problem hiding this comment.
replace markAsync with env.yieldAndRun and completableFuture for Ballerina extern functions
warunalakshitha
merged commit 44d112e
into
ballerina-platform:java21
3 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Examples
Checklist