Fix patch step for OCCT and OpenCV dependencies #5966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PATCH_COMMAND
for OCCT and OpenCV are trying to patch files that don't exist because of the addition of the--directory
flag.PATCH_COMMAND
runs in the working directory of the downloaded source files per my own testing. Specifying--directory
here is causing the patch to try to apply todep_OpenCV-prefix/src/OpenCV
from root of the downloaded source rather than from the root of the downloaded source code. This causesgit apply
to try to patch files that don't exist which returns nonzero error codes (I can only reproduce this behavior ofgit apply
when the--directory
flag is present, without it the patch fails silently). I have a comment going into a bit more depth about this here.This is leading to the build failures and workaround being discussed in #4158, #4689, #5171.
With these changes I'm able to fully cleanbuild on Arch Linux.