Skip to content

Commit a1a5013

Browse files
authored
Update apple release_name for version >= 18 (#382)
As shown in commit 6c57c24, the newer apple releases seem to use `apple-macos11` instead of `apple-darwin22.0`. (Though I am not sure what would be used for x86, since I can't find such a build for llvm version >= 18.) Also, if this is merged, can we get a new toolchains_llvm release (v1.1.3) shortly after? The most recent apple binary currently available in v1.1.2 is quite old.
1 parent 6c57c24 commit a1a5013

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

toolchain/internal/release_name.bzl

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,16 @@ def _darwin_apple_suffix(llvm_version, arch):
2727
return "apple-darwin21.0"
2828
else:
2929
return "apple-darwin"
30-
elif major_llvm_version >= 15:
30+
elif major_llvm_version >= 15 and major_llvm_version < 18:
3131
if arch == "arm64":
3232
return "apple-darwin22.0"
3333
else:
3434
return "apple-darwin21.0"
35+
elif major_llvm_version >= 18:
36+
if arch == "arm64":
37+
return "apple-macos11"
38+
else:
39+
return "apple-darwin21.0"
3540
else:
3641
return "apple-darwin"
3742

0 commit comments

Comments
 (0)