Skip to content

cc_wrapper.sh.tpl has comment referring to old approach that has long been replaced #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pagten opened this issue Mar 24, 2025 · 0 comments

Comments

@Pagten
Copy link

Pagten commented Mar 24, 2025

I happened to be reading the cc_wrapper.sh.tpl file, which has the following comment at the top:

# OS X relpath is not really working. This is a wrapper script around gcc
# to simulate relpath behavior.
#
# This wrapper uses install_name_tool to replace all paths in the binary
# (bazel-out/.../path/to/original/library.so) by the paths relative to
# the binary. It parses the command line to behave as rpath is supposed
# to work.
#
# See https://blogs.oracle.com/dipol/entry/dynamic_libraries_rpath_and_mac
# on how to set those paths for Mach-O binaries.

This comment appears to be referring to the solution implemented in the initial version of cc_wrapper.sh.tpl in this commit. That solution was completely replaced with a different approach in this commit, however. The comment still refers to the old approach, which can be confusing when trying to understand what the wrapper script is doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant