Tweaks #489
Merged
Tweaks #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sort known distro names. * Function `_os_version_arch` returns a dist(ribution) name and not an os name, so we rename it `_dist_version_arch`. * Move `_resolve_version_for_suse` above `_linux` to follow order of the other helpers. * Improve strip_prefix detection (also added `.exe` as we predict it, though we cannot really handle it (yet)).
fmeum
approved these changes
Apr 26, 2025
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks:
_os_version_archreturns a dist(ribution) name and not an os name, so we rename it_dist_version_arch._resolve_version_for_suseabove_linuxto follow order of the other helpers..exeas we predict it, though we cannot really handle it (yet)).