Skip to content

Add support for x86_64-unknown-none targets #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

jblebrun
Copy link
Contributor

By default, no sysroot is used.

This is useful for bare-metal targets, firmwares, etc.

We are actively using this patch in https://github.com/project-oak/oak

@jblebrun jblebrun force-pushed the x86_64-unknown-none-support branch from eb06759 to 7e3498a Compare May 21, 2025 04:26
@fmeum fmeum enabled auto-merge (squash) May 21, 2025 08:25
@fmeum
Copy link
Member

fmeum commented May 21, 2025

Could you look into the CI failures?

auto-merge was automatically disabled May 21, 2025 15:47

Head branch was pushed to by a user without write access

@jblebrun jblebrun force-pushed the x86_64-unknown-none-support branch from 7e3498a to c04c191 Compare May 21, 2025 15:47
@jblebrun
Copy link
Contributor Author

Could you look into the CI failures?

Taking a look. It looks like a lot of the failures are due to wasm failures, because of missing headers. I wonder if it's due to the sysroot change I made.

I can't reproduce the failure locally, so I created commenting this out and pushing again.

@jblebrun
Copy link
Contributor Author

I can't reproduce the failure locally, so I created commenting this out and pushing again.

Update: I found a local repro. I will figure out what's happening and push a new update. So you can hold off on enabling the current CI run.

By default, no sysroot is used.

This is useful for bare-metal targets, firmwares, etc.

We are actively using this patch in https://github.com/project-oak/oak
@jblebrun jblebrun force-pushed the x86_64-unknown-none-support branch from c04c191 to 24aa298 Compare May 21, 2025 18:26
@jblebrun
Copy link
Contributor Author

Ok, I figured it out. Checking on os == "none" alone was also allowing wasm32|64-none-none to pass.

To fix it, I've created a list of target pairs that should support no-sysroot.

It seems it should be theoretically possible to support wasm-none as well, but that might be a deeper change?

@jblebrun
Copy link
Contributor Author

jblebrun commented May 21, 2025

@fmeum This PR is ready for another test pass whenever you get a chance to click the button.

@fmeum fmeum merged commit 0d3594c into bazel-contrib:master May 21, 2025
36 checks passed
@jblebrun
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants