Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port testing from nose to pytest. #192

Merged
merged 6 commits into from
Jul 30, 2020
Merged

Port testing from nose to pytest. #192

merged 6 commits into from
Jul 30, 2020

Conversation

mcepl
Copy link
Contributor

@mcepl mcepl commented Jul 22, 2020

Fixes #188

bbangert
bbangert approved these changes Jul 30, 2020
View reviewed changes
Copy link
Owner

@bbangert bbangert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work!

@bbangert bbangert merged commit 5e18a5a into bbangert:master Jul 30, 2020
@mcepl mcepl deleted the denose branch July 31, 2020 07:22
@amol-
Copy link
Collaborator

amol- commented Jul 31, 2020

I actually didn't merge it yet because I wanted to fix the coverage reporting before merging, but didn't get a chance to do it.
(See that with nose we had coverage -> https://travis-ci.org/github/bbangert/beaker/jobs/689422375#L488 while with pytest we got it no more -> https://travis-ci.org/github/bbangert/beaker/jobs/713496048#L572 ) It's just a matter of adding pytest-cov, but I wanted also to check the setup.cfg because the options there were for nose and not all of them are compatible.

Not bad, I'll just do this on master :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbangert bbangert bbangert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nose won't be supported starting with Python 3.9/3.10
3 participants
@mcepl @amol- @bbangert