-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFE: drop python<=3.7 support #239
Comments
Install base of Python 3.7 and 3.8 constitutes >50% of all installed python versions (see https://w3techs.com/technologies/history_details/pl-python/3 for example) and specifically to beaker, Python 2.7 is still the 4th most used version with 3.7 being the 3rd: https://pypistats.org/packages/beaker Beaker should follow the demand from its users, not force them to upgrade unless it's necessary. |
This RFE i snot about abandon support of any of those python versions. 😄 |
I'm not convinced that it would compensate the labour necessary to maintain two branches, practically rewriting everything twice, especially as the codebase starts to diverge and thus changes might not easily merge anymore. Plus the initial effort at upgrading the codebase (and no, |
Please .. I'm not talking about create two branches. I'm talking about one branch and backport only critical fixes.
Please try to have closer look closer on what is possible to remove more after that automatic filtering all code. |
I have no interest in backporting only critical fixes given that the Beaker users of versions < 3.9 are still the majority, so it would imply maintaining two branches. I still don't see the benefit of this and I will personally phase out Python versions when I see them going in disuse between our users. |
Python 2.x has been EOSed more than 4 years ago and python 3.7 Jun last year.
https://endoflife.date/python
IMO it would be good to create 1.x branch and commit on that branch only critical fixes and start working on remove first all python 2.x support and than clean the code do drop python<=3.7.
First new stable release can be like 2.0.0.
pyupgrade --py38-plus
command generated +28KB patch on top of which is possible to make probably another ~20KBmanual changes.PS. Sep this year will be EOSed python 3.8 but if all code up to then will be cleaned remove python 3.8 support can be almost instantly generated using
pyupgrade --py39-plus
commend.The text was updated successfully, but these errors were encountered: