Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy date calculation in ._delete_cookie #6

Closed
mikeorr opened this issue Mar 1, 2012 · 2 comments
Closed

Buggy date calculation in ._delete_cookie #6

mikeorr opened this issue Mar 1, 2012 · 2 comments

Comments

@mikeorr
Copy link

mikeorr commented Mar 1, 2012

beaker.session.Session._delete_cookie() contains a buggy date calculation.

expires = datetime.utcnow().replace(year=2003)

On February 29th of a leap year this raises:

ValueError: day is out of range for month

The apparent goal is to set a date in the past. Can't it just use a fixed date like '2003-01-01'?

@bbangert
Copy link
Owner

bbangert commented Mar 1, 2012

Yep, this was actually fixed yesterday, and the new Beaker release contains it.

@bbangert bbangert closed this as completed Mar 1, 2012
@dkavanagh
Copy link

Linking to fix: b5afb4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants