Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating standards page to include marking information #1501

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

AMEIJER1
Copy link
Collaborator

Description of Changes

  • created standards/markings api
  • added markings tab/page on standards page to request information from new api endpoint

Testing Notes

-make fix succeeded

@AMEIJER1 AMEIJER1 added the Ready For Review PR is ready for review label Feb 19, 2025
@AMEIJER1 AMEIJER1 requested a review from mauberti-bc February 19, 2025 20:18
@AMEIJER1 AMEIJER1 self-assigned this Feb 19, 2025
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 4.34783% with 44 lines in your changes missing coverage. Please review.

Project coverage is 47.49%. Comparing base (9ede5f5) to head (cde311f).

Files with missing lines Patch % Lines
api/src/paths/standards/markings/index.ts 0.00% 15 Missing ⚠️
...tures/standards/view/markings/MarkingStandards.tsx 0.00% 10 Missing ⚠️
...tandards/view/markings/MarkingStandardsResults.tsx 0.00% 9 Missing ⚠️
api/src/services/standards-service.ts 0.00% 5 Missing ⚠️
app/src/hooks/api/useStandardsApi.ts 20.00% 4 Missing ⚠️
app/src/features/standards/StandardsPage.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1501      +/-   ##
==========================================
- Coverage   47.57%   47.49%   -0.08%     
==========================================
  Files         926      929       +3     
  Lines       24182    24229      +47     
  Branches     3609     3616       +7     
==========================================
+ Hits        11505    11508       +3     
- Misses      12043    12087      +44     
  Partials      634      634              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant