-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIMSBIOHUB-668a cross-referencing device keys with telemetry data #1502
base: dev
Are you sure you want to change the base?
Conversation
Openshift URLs for the PR Deployment: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1502 +/- ##
==========================================
- Coverage 47.57% 47.56% -0.01%
==========================================
Files 926 926
Lines 24182 24189 +7
Branches 3609 3609
==========================================
+ Hits 11505 11506 +1
- Misses 12043 12049 +6
Partials 634 634 ☔ View full report in Codecov by Sentry. |
|
* @param {Knex.QueryBuilder} queryBuilder | ||
* @returns {Knex.QueryBuilder} | ||
*/ | ||
private static getLotekOrVectronicTelemetryByCredentialsClause(queryBuilder: Knex.QueryBuilder): Knex.QueryBuilder { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: do you mind if we remove private
.
None of the code in this app is going to be used by anyone else so we don't really benefit from hiding the functions. It can also make unit testing more annoying as you cant directly reference or mock private functions (even though in this case we don't need to test these functions, since they don't actually have any proper logic or decision making).
Links to Jira Tickets
Description of Changes
Testing Notes