Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIMSBIOHUB-668a cross-referencing device keys with telemetry data #1502

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

oscar-ip
Copy link
Collaborator

Links to Jira Tickets

  • SIMSBIOHUB-668

Description of Changes

  • cross-referencing device keys with telemetry data
  • added filter for get and find methods to show telemetry data for loaded keys

Testing Notes

  • Limited local testing with an admin user more testing with non admin user needed

@oscar-ip oscar-ip added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Feb 20, 2025
@oscar-ip oscar-ip requested a review from NickPhura February 20, 2025 02:02
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.56%. Comparing base (9ede5f5) to head (ce6c22e).

Files with missing lines Patch % Lines
...emetry-repositories/telemetry-vendor-repository.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1502      +/-   ##
==========================================
- Coverage   47.57%   47.56%   -0.01%     
==========================================
  Files         926      926              
  Lines       24182    24189       +7     
  Branches     3609     3609              
==========================================
+ Hits        11505    11506       +1     
- Misses      12043    12049       +6     
  Partials      634      634              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* @param {Knex.QueryBuilder} queryBuilder
* @returns {Knex.QueryBuilder}
*/
private static getLotekOrVectronicTelemetryByCredentialsClause(queryBuilder: Knex.QueryBuilder): Knex.QueryBuilder {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do you mind if we remove private.

None of the code in this app is going to be used by anyone else so we don't really benefit from hiding the functions. It can also make unit testing more annoying as you cant directly reference or mock private functions (even though in this case we don't need to test these functions, since they don't actually have any proper logic or decision making).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early Feedback Welcome PR is not finished, but early review feedback is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants