properties + anyOf generates incorrect output

[gborobio73]

Given this schema:

{
  "type": "object",
  "additionalProperties": false,
  "properties": {
    "id": {
      "type": "string"
    },
    "validFrom": {
      "type": "string"
    },
    "validTo": {
      "type": "string"
    }
  },
  "anyOf": [
    {
      "required": ["id", "validFrom"]
    },
    {
      "required": ["id", "validTo"]
    }
  ],
  "title": "Assortment"
}

This is the type generated:

export type Assortment = Assortment1 & Assortment2;
export type Assortment1 = {
  [k: string]: unknown;
};

export interface Assortment2 {
  id?: string;
  validFrom?: string;
  validTo?: string;
}

And I was hoping it would generate something like this:

export type Assortment =
  | {
      id: string;
      validFrom: string;
      validTo?: string;
    }
  | {
      id: string;
      validFrom?: string;
      validTo: string;
    };

I might be doing something wrong, so my apologies in advance.

Thank you so much!

[LukasFritzeDev]

This technique is called Factoring Schemas in the documentation and should work.

A simpler sample would be

{
  "type": "string",
  "oneOf": [
    {
      "description": "Name of resource.",
      "pattern": "^d[0-9]+$"
    },
    {
      "description": "Id (uuid) of resource.",
      "format": "uuid"
    }
  ]
}

produces this type:

{
  [k: string]: unknown;
} & string;

when I’d expect

string | string

or just

string

[petrosv91]

Any update on this? Or a workaround?

[drewhoener]

oh good this is an actual issue, I thought I just didn't understand json schema lol
+1