Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update slither #194

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: update slither #194

merged 1 commit into from
Oct 1, 2024

Conversation

livingrockrises
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (87fc1ed) to head (cb44a69).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #194   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          14       14           
  Lines         922      922           
  Branches      275      275           
=======================================
  Hits          790      790           
  Misses        117      117           
  Partials       15       15           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87fc1ed...cb44a69. Read the comment docs.

Copy link

github-actions bot commented Oct 1, 2024

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ERC7739Validator.sol#L279-L309

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

@livingrockrises livingrockrises merged commit 8a9b410 into dev Oct 1, 2024
12 checks passed
@livingrockrises livingrockrises deleted the fix/update-slither branch October 1, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants