Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/readme cleanup #208

Closed
wants to merge 2 commits into from
Closed

refactor/readme cleanup #208

wants to merge 2 commits into from

Conversation

VGabriel45
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.68%. Comparing base (9937eef) to head (88175c8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #208   +/-   ##
=======================================
  Coverage   85.68%   85.68%           
=======================================
  Files          14       14           
  Lines         943      943           
  Branches      256      256           
=======================================
  Hits          808      808           
  Misses        120      120           
  Partials       15       15           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e7f3ab...88175c8. Read the comment docs.

@livingrockrises
Copy link
Contributor

PR checks fail. if you can, close this PR and open new one that passes branch name checking rules.

@livingrockrises
Copy link
Contributor

why do we need kernel submodule? it's updated in this PR

also, gas reports CI job shouldn't have failed

@VGabriel45 VGabriel45 changed the title refactor: readme cleanup refactor/readme cleanup Oct 23, 2024
@VGabriel45 VGabriel45 closed this Oct 23, 2024
Copy link

Changes to gas cost

Generated at commit: 6d14ce138e0d594d6a1057a802f78fd41460ccbd, compared to commit: 773943fb7bf6cd14a0dc6dcb9f513db53213d1d5

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
MockPaymaster 1,063,705 (+187)
HelperConfig 6,941,247 (+3,159,382)

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)
🟡 - unused-return (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

base/ERC7739Validator.sol#L279-L309

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

@filmakarov filmakarov deleted the refactor/readme-cleanup branch December 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants