Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked/7739 validator base as external dep #214

Conversation

filmakarov
Copy link
Collaborator

Use as dependency

Copy link

github-actions bot commented Oct 30, 2024

Changes to gas cost

Generated at commit: baeb31221738d6882a128e095d5f8c49571e192c, compared to commit: 17f12b46828b0f7efde2af38ea7219a99e3c9e72

🧾 Summary (5% most significant diffs)

Contract Method Avg (+/-) %

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
MockPaymaster 1,063,705 (+187)
HelperConfig 7,039,537 (+3,257,672)

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L165

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L39

_This comment was automatically generated by the GitHub Actions workflow._

Copy link

openzeppelin-code bot commented Oct 30, 2024

Stacked/7739 validator base as external dep

Generated at commit: 94d85f9f26064c7138b7905454df0ca4ca545698

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
27
35

For more details view the full report in OpenZeppelin Code Inspector

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (fix/k1validator-7739@17f12b4). Learn more about missing BASE report.

Additional details and impacted files
@@                   Coverage Diff                   @@
##             fix/k1validator-7739     #214   +/-   ##
=======================================================
  Coverage                        ?   72.51%           
=======================================================
  Files                           ?       12           
  Lines                           ?      564           
  Branches                        ?      153           
=======================================================
  Hits                            ?      409           
  Misses                          ?      155           
  Partials                        ?        0           
Files with missing lines Coverage Δ
contracts/modules/validators/K1Validator.sol 59.01% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f12b4...94d85f9. Read the comment docs.

@livingrockrises livingrockrises merged commit a7f8b32 into fix/k1validator-7739 Oct 31, 2024
8 of 11 checks passed
@livingrockrises livingrockrises deleted the stacked/7739-validator-base-as-external-dep branch October 31, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants