Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERC-7779 support v 0.1 #231

Merged

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Dec 18, 2024

Draft implementation of ERC-7779 support for Nexus


PR-Codex overview

This PR focuses on enhancing the functionality of the Nexus contract and related components by integrating the ERC7779Adapter, which facilitates storage management and redelegation features for smart accounts.

Detailed summary

  • Added function _amIERC7702() in BaseAccount to check contract code.
  • Introduced MockERC7779 contract for testing ERC7779Adapter.
  • Updated IModuleManagerEventsAndErrors with new events.
  • Changed _STORAGE_LOCATION to _NEXUS_STORAGE_LOCATION in Storage.
  • Enhanced INexus interface to include IERC7779.
  • Implemented ERC7779Adapter for managing storage bases.
  • Added functions in ModuleManager for uninstalling validators, executors, and hooks.
  • Updated Nexus to utilize ERC7779Adapter and handle storage during redelegation.
  • Created tests for ERC7779Adapter and redelegation logic in TestFuzz_ERC7779Adapter and TestEIP7702.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

openzeppelin-code bot commented Dec 18, 2024

ERC-7779 support v 0.1

Generated at commit: 40630e8b2f07ad536a36462efe8692f6ae673b34

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
29
37

For more details view the full report in OpenZeppelin Code Inspector

Copy link

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L185

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

@filmakarov filmakarov changed the base branch from dev to release/eip-7702-sepolia-pre-release February 6, 2025 15:04
@filmakarov filmakarov changed the title ERC 7779 support ERC-7779 support Feb 6, 2025
@filmakarov filmakarov mentioned this pull request Feb 6, 2025
2 tasks
@filmakarov filmakarov changed the title ERC-7779 support ERC-7779 support v 0.1 Feb 6, 2025
@filmakarov filmakarov merged commit d8078a9 into release/eip-7702-sepolia-pre-release Feb 6, 2025
4 of 6 checks passed
@filmakarov filmakarov deleted the feat/erc-7779-support branch February 6, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant