Secure batch decode implementation #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add secure decodeBatch implementation
https://github.com/Vectorized/solady/blob/21e3649841829dd3b265d1228defefb23b5d977b/src/accounts/LibERC7579.sol#L149
PR-Codex overview
This PR focuses on enhancing the functionality of the
MockExecutor
contract and its tests by modifying execution handling, particularly for batch executions, and improving thedecodeBatch
function's implementation for better safety and clarity.Detailed summary
executeFromExecutor
function inMockExecutor
to handle additional execution cases.Execution
array from 1 to 2 for batch processing.decodeBatch
function inExecLib
for improved safety and clarity using memory-safe assembly.TestAccountExecution_ExecuteFromExecutor
to accommodate changes in execution handling and ensure the correct revert conditions are checked.