Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Module Enable Mode compatible with 7702 #236

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

filmakarov
Copy link
Collaborator

@filmakarov filmakarov commented Feb 3, 2025

  • Module Enable Mode can verify enable sig from account itself (similar to validateUserOp)

PR-Codex overview

This PR focuses on enhancing the functionality and security of the Nexus contract and related modules, particularly for EIP-7702 accounts. It introduces new mechanisms for handling user operations and improves signature validation processes.

Detailed summary

  • Updated DEFAULT_BASE_RPC_URL in BaseSettings.t.sol.
  • Refactored signature handling in TestHelper contract.
  • Added tests for enabling modes in TestModuleManager_EnableMode.t.sol.
  • Improved validation checks in Nexus contract, including _hasValidators() and _hasExecutors().
  • Replaced _checkUserOpSignature with _checkSelfSignature for better validation.
  • Added initialization checks for validators and executors in ModuleManager.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

openzeppelin-code bot commented Feb 3, 2025

Make Module Enable Mode compatible with 7702

Generated at commit: 1e4eab1ae09fb6fa4f431c575c60a2b794aa35e5

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
1
0
6
29
37

For more details view the full report in OpenZeppelin Code Inspector

@filmakarov filmakarov merged commit f611a15 into dev Feb 3, 2025
5 checks passed
@filmakarov filmakarov deleted the feat/7702-compatible-moduleEnableMode branch February 3, 2025 16:18
Copy link

github-actions bot commented Feb 3, 2025

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

utils/NexusBootstrap.sol#L33-L185

constable-states

Impact: Optimization
🔴 Confidence: High

base/RegistryAdapter.sol#L10

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant