Pre issued 1271 sigs handling

[filmakarov]

From EP 0.8 pre-release notes:

Compatible ERC-1271 signature
EIP-7702 accounts could have off-chain signatures created prior to adding an account code. To keep those signature working, account SHOULD make sure that ERC-1271 signature are compatible
Again, see the reference implementation

However, I found it potentially unsafe to just allow such signatures.

// 1. This 7702 account being an eoa as well owns some other Smart Account (Smart Account B)
// 2. It signs some unsafe hash: the one that doesn't have Smart Account B address hashed in
// 3. In this case, if we just allow signatures by address(this), this above sig
//    over unsafe hash could be replayed here

So instead of allowing such sigs, decided to revert but with a specific custom error

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

# Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - locked-ether (1 results) (Medium)

• constable-states (2 results) (Optimization)

locked-ether

🟡 Impact: Medium
🔴 Confidence: High

• ID-0
  Contract locking ether found:
  Contract NexusBootstrap has payable functions:
  • ModuleManager.receive()
  • ModuleManager.fallback(bytes)
  • NexusBootstrap.initNexusWithSingleValidator(IModule,bytes,IERC7484,address[],uint8)
  • NexusBootstrap.initNexus(BootstrapConfig[],BootstrapConfig[],BootstrapConfig,BootstrapConfig[],IERC7484,address[],uint8)
  • NexusBootstrap.initNexusScoped(BootstrapConfig[],BootstrapConfig,IERC7484,address[],uint8)
    But does not have a function to withdraw the ether

utils/NexusBootstrap.sol#L33-L185

constable-states

Impact: Optimization
🔴 Confidence: High

• ID-1
  RegistryAdapter.registry should be constant

base/RegistryAdapter.sol#L10

• ID-2
  RegistryFactory.threshold should be constant

factory/RegistryFactory.sol#L38

_This comment was automatically generated by the GitHub Actions workflow._

[openzeppelin-code]

Pre issued 1271 sigs handling

Generated at commit: 46df04657d7b96cd76285406125dcc888db7c57a

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	1 1 0 6 29 37

---

For more details view the full report in OpenZeppelin Code Inspector