Feat/gas diff fix

[Aboudjem]

No description provided.

[github-actions]

🤖 Slither Analysis Report 🔎

Slither report

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results.
Summary
🟡 - unused-return (5 results) (Medium)
🔵 - shadowing-local (1 results) (Low)
🔵 - missing-zero-check (1 results) (Low)
🔵 - reentrancy-events (5 results) (Low)
ℹ️ - assembly (18 results) (Informational)
ℹ️ - dead-code (5 results) (Informational)
ℹ️ - low-level-calls (1 results) (Informational)
ℹ️ - naming-convention (5 results) (Informational)
ℹ️ - redundant-statements (1 results) (Informational)
ℹ️ - too-many-digits (1 results) (Informational)

unused-return

🟡 Impact: Medium
🟡 Confidence: Medium

• ID-0
  ModuleManager._getValidatorsPaginated(address,uint256) ignores return value by validators.getEntriesPaginated(cursor,size)

base/ModuleManager.sol#L284-L290

• ID-1
  SmartAccount.executeFromExecutor(ExecutionMode,bytes) ignores return value by (callType,execType) = mode.decode()

SmartAccount.sol#L76-L118

• ID-2
  ModuleManager._getExecutorsPaginated(address,uint256) ignores return value by executors.getEntriesPaginated(cursor,size)

base/ModuleManager.sol#L292-L298

• ID-3
  SmartAccount.execute(ExecutionMode,bytes) ignores return value by (callType,execType) = mode.decode()

SmartAccount.sol#L57-L68

• ID-4
  SmartAccount.supportsExecutionMode(ExecutionMode) ignores return value by (callType,execType) = mode.decode()

SmartAccount.sol#L224-L246

shadowing-local

🔵 Impact: Low
🔴 Confidence: High

• ID-5
  SmartAccount.validateUserOp(PackedUserOperation,bytes32,uint256).nonce shadows:
  • BaseAccount.nonce(uint192) (function)

SmartAccount.sol#L37

missing-zero-check

🔵 Impact: Low
🟡 Confidence: Medium

• ID-6
  AccountFactory.constructor(address).implementation lacks a zero-check on :
  - ACCOUNT_IMPLEMENTATION = implementation

factory/AccountFactory.sol#L11

reentrancy-events

🔵 Impact: Low
🟡 Confidence: Medium

• ID-7
  Reentrancy in SmartAccount.uninstallModule(uint256,address,bytes):
  External calls:
  • _uninstallValidator(module,deInitData)
    • IValidator(validator).onUninstall(disableModuleData)
  • _uninstallExecutor(module,deInitData)
    • IExecutor(executor).onUninstall(disableModuleData)
  • _uninstallFallbackHandler(module,deInitData)
    • IFallback(fallbackHandler).onUninstall(deInitData)
  • _uninstallHook(module,deInitData)
    • IHook(hook).onUninstall(data)
      Event emitted after the call(s):
  • ModuleUninstalled(moduleTypeId,module)

SmartAccount.sol#L160-L175

• ID-8
  Reentrancy in SmartAccount.installModule(uint256,address,bytes):
  External calls:
  • (hook,hookData) = _preCheck()
    • hookData = IHook(hook).preCheck(msg.sender,msg.value,msg.data)
  • _installValidator(module,initData)
    • IValidator(validator).onInstall(data)
  • _installExecutor(module,initData)
    • IExecutor(executor).onInstall(data)
  • _installFallbackHandler(module,initData)
    • IFallback(handler).onInstall(initData)
  • _installHook(module,initData)
    • IHook(hook).onInstall(data)
      Event emitted after the call(s):
  • ModuleInstalled(moduleTypeId,module)

SmartAccount.sol#L133-L156

• ID-9
  Reentrancy in AccountFactory.createAccount(address,bytes,uint256):
  External calls:
  • IBicoMSA(account).initialize(validationModule,moduleInstallData)
    Event emitted after the call(s):
  • AccountCreated(account,validationModule,moduleInstallData)

factory/AccountFactory.sol#L22-L40

• ID-10
  Reentrancy in SmartAccount.executeFromExecutor(ExecutionMode,bytes):
  External calls:
  • (hook,hookData) = _preCheck()
    • hookData = IHook(hook).preCheck(msg.sender,msg.value,msg.data)
      Event emitted after the call(s):
  • TryExecuteUnsuccessful(i,result[i])
    • returnData = _tryExecute(executions)
  • TryExecuteUnsuccessful(0,returnData[0])

SmartAccount.sol#L76-L118

• ID-11
  Reentrancy in SmartAccount.execute(ExecutionMode,bytes):
  External calls:
  • (hook,hookData) = _preCheck()
    • hookData = IHook(hook).preCheck(msg.sender,msg.value,msg.data)
      Event emitted after the call(s):
  • TryExecuteUnsuccessful(i,result[i])
    • _handleBatchExecution(executionCalldata,execType)

SmartAccount.sol#L57-L68

assembly

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-12
  ModuleManager.fallback.asm_0.allocate() uses assembly
  • INLINE ASM

base/ModuleManager.sol#L81-L84

• ID-13
  ModuleManager.fallback.asm_1.allocate() uses assembly
  • INLINE ASM

base/ModuleManager.sol#L107-L110

• ID-14
  Storage._getAccountStorage() uses assembly
  • INLINE ASM

base/Storage.sol#L18-L22

• ID-15
  SmartAccount.getImplementation() uses assembly
  • INLINE ASM

SmartAccount.sol#L206-L210

• ID-16
  ExecutionHelper._executeDelegatecall(address,bytes) uses assembly
  • INLINE ASM

base/ExecutionHelper.sol#L82-L98

• ID-17
  ExecutionHelper._tryExecuteDelegatecall(address,bytes) uses assembly
  • INLINE ASM

base/ExecutionHelper.sol#L101-L116

• ID-18
  ModeLib.decode(ExecutionMode) uses assembly
  • INLINE ASM

lib/ModeLib.sol#L91-L104

• ID-19
  BaseAccount.getDeposit() uses assembly
  • INLINE ASM

base/BaseAccount.sol#L73-L89

• ID-20
  SmartAccount.validateUserOp(PackedUserOperation,bytes32,uint256) uses assembly
  • INLINE ASM

SmartAccount.sol#L31-L47

• ID-21
  ExecutionHelper._tryExecute(address,uint256,bytes) uses assembly
  • INLINE ASM

base/ExecutionHelper.sol#L64-L79

• ID-22
  BaseAccount.withdrawDepositTo(address,uint256) uses assembly
  • INLINE ASM

base/BaseAccount.sol#L105-L118

• ID-23
  ExecLib.decodeBatch(bytes) uses assembly
  • INLINE ASM

lib/ExecLib.sol#L13-L29

• ID-24
  ModeLib.getCallType(ExecutionMode) uses assembly
  • INLINE ASM

lib/ModeLib.sol#L134-L138

• ID-25
  SmartAccount.fallback.asm_1.allocate() uses assembly
  • INLINE ASM

base/ModuleManager.sol#L107-L110

• ID-26
  BaseAccount.addDeposit() uses assembly
  • INLINE ASM

base/BaseAccount.sol#L92-L102

• ID-27
  ModuleManager.fallback() uses assembly
  • INLINE ASM
  • INLINE ASM

base/ModuleManager.sol#L73-L131

• ID-28
  ExecutionHelper._execute(address,uint256,bytes) uses assembly
  • INLINE ASM

base/ExecutionHelper.sol#L43-L62

• ID-29
  SmartAccount.fallback.asm_0.allocate() uses assembly
  • INLINE ASM

base/ModuleManager.sol#L81-L84

dead-code

ℹ️ Impact: Informational
🟡 Confidence: Medium

• ID-30
  ExecutionHelper._executeDelegatecall(address,bytes) is never used and should be removed

base/ExecutionHelper.sol#L82-L98

• ID-31
  ExecutionHelper._tryExecuteDelegatecall(address,bytes) is never used and should be removed

base/ExecutionHelper.sol#L101-L116

• ID-32
  _eqModeSelector(ModeSelector,ModeSelector) is never used and should be removed

lib/ModeLib.sol#L158-L160

• ID-33
  ModuleManager.fallback.asm_0.allocate() is never used and should be removed

base/ModuleManager.sol#L81-L84

• ID-34
  ModuleManager.fallback.asm_1.allocate() is never used and should be removed

base/ModuleManager.sol#L107-L110

low-level-calls

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-35
  🔵 Low level call in SmartAccount.executeUserOp(PackedUserOperation,bytes32):
  • (success) = address(this).delegatecall(callData)

SmartAccount.sol#L122-L129

naming-convention

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-36
  Variable AccountFactory.ACCOUNT_IMPLEMENTATION is not in mixedCase

factory/AccountFactory.sol#L9

• ID-37
  Parameter ModuleManager.fallback.asm_1.allocate().length_fallback_asm_1_allocate is not in mixedCase

base/ModuleManager.sol#L107

• ID-38
  Parameter SmartAccount.fallback.asm_1.allocate().length_fallback_asm_1_allocate is not in mixedCase

base/ModuleManager.sol#L107

• ID-39
  Parameter ModuleManager.fallback.asm_0.allocate().length_fallback_asm_0_allocate is not in mixedCase

base/ModuleManager.sol#L81

• ID-40
  Parameter SmartAccount.fallback.asm_0.allocate().length_fallback_asm_0_allocate is not in mixedCase

base/ModuleManager.sol#L81

redundant-statements

ℹ️ Impact: Informational
🔴 Confidence: High

• ID-41
  Redundant expression "additionalContext" inSmartAccount

SmartAccount.sol#L291

too-many-digits

ℹ️ Impact: Informational
🟡 Confidence: Medium

• ID-42
  BaseAccount.withdrawDepositTo(address,uint256) uses literals with too many digits:
  • mstore(uint256,uint256)(0x00,0x205c2878000000000000000000000000)

base/BaseAccount.sol#L105-L118

This comment was automatically generated by the GitHub Actions workflow.