Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead coordinate system code #274

Closed
wants to merge 4 commits into from
Closed

Conversation

tonypr
Copy link
Collaborator

@tonypr tonypr commented Jun 30, 2024

The code being removed is not referenced elsewhere in the code base (i.e. it's dead code). Removing to help reduce the size of the code base overall.

@tonypr tonypr requested a review from bcollazo June 30, 2024 01:41
Copy link

netlify bot commented Jun 30, 2024

👷 Deploy request for catanatron-staging pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 655b0c4

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9728435812

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 95.804%

Totals Coverage Status
Change from base Build 8157180417: -0.07%
Covered Lines: 1347
Relevant Lines: 1406

💛 - Coveralls

@tonypr tonypr changed the title Remove dead cube conversion code Remove dead coordinate system code Jun 30, 2024
@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9728786968

Details

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 95.851%

Totals Coverage Status
Change from base Build 8157180417: -0.02%
Covered Lines: 1340
Relevant Lines: 1398

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9729177722

Details

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 95.696%

Files with Coverage Reduction New Missed Lines %
catanatron_core/catanatron/models/actions.py 1 96.03%
Totals Coverage Status
Change from base Build 8157180417: -0.2%
Covered Lines: 1334
Relevant Lines: 1394

💛 - Coveralls

@tonypr
Copy link
Collaborator Author

tonypr commented Jun 30, 2024

Whoops, I only wanted to submit a PR for some changes, not what's currently at "master" on my forked repo. Closing

@tonypr tonypr closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants