Skip to content

Upgrade activerecord to 7.2 and refactor code for new version #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Nov 6, 2024

Conversation

zinduolis
Copy link
Contributor

Pull Request

Thanks for submitting a PR! Please fill in this template where appropriate:

Category

Bug

Feature/Issue Description

Q: Please give a brief summary of your feature/fix
A: Upgrade activerecord to 7.2 and refactor code for new version

Q: Give a technical rundown of what you have changed (if applicable)
A: Fix activerecord migration code to be compatible with the new version and upgrade the version of activerecord

Test Cases

Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: bundle exec rake, debug modules, browserstack tests.

Wiki Page

If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.

@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 4, 2024 05:59 — with GitHub Actions Failure
@zinduolis
Copy link
Contributor Author

To apply the activerecord upgrade, requires ruby version upgrade. Investigating.

@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 4, 2024 08:27 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 4, 2024 08:43 — with GitHub Actions Failure
@zinduolis
Copy link
Contributor Author

zinduolis commented Nov 4, 2024

The PR is running with the old ruby version (3.0.3) that is cached somewhere. I'm investigating.

@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 4, 2024 08:52 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 4, 2024 09:11 — with GitHub Actions Failure
@zinduolis
Copy link
Contributor Author

It looks like the GitHub actions are running of master branch where the older ruby version is specified. I'll raise a separate PR to update GitHub actions and then continue with this one.

dependabot bot and others added 2 commits November 4, 2024 13:51
Bumps [jsdoc-to-markdown](https://github.com/jsdoc2md/jsdoc-to-markdown) from 9.0.4 to 9.0.5.
- [Release notes](https://github.com/jsdoc2md/jsdoc-to-markdown/releases)
- [Commits](jsdoc2md/jsdoc-to-markdown@v9.0.4...v9.0.5)

---
updated-dependencies:
- dependency-name: jsdoc-to-markdown
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…nd_yarn/jsdoc-to-markdown-9.0.5

Bump jsdoc-to-markdown from 9.0.4 to 9.0.5
@zinduolis zinduolis self-assigned this Nov 5, 2024
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 5, 2024 09:58 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 5, 2024 10:00 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 5, 2024 10:09 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 5, 2024 10:11 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 5, 2024 22:28 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 6, 2024 04:34 — with GitHub Actions Failure
@zinduolis zinduolis had a problem deploying to Integrate Pull Request November 6, 2024 04:42 — with GitHub Actions Failure
@zinduolis zinduolis temporarily deployed to Integrate Pull Request November 6, 2024 04:48 — with GitHub Actions Inactive
@zinduolis zinduolis merged commit 3136718 into beefproject:master Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant