Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] set PO line name with onchange_product_id #539

Merged

Conversation

victor-champonnois
Copy link
Member

@victor-champonnois victor-champonnois commented Feb 24, 2025

Description

This will set the correct description on the line based on supplierinfo product_name.

  • currently the product template name is used, instead of supplierinfo.product_name
  • the computation of the name is doing what Odoo is already doing, let's remove it and let Odoo compute the description when creating the PO line.

I don't know why precommit fails but it's not due to the new code. It runs fine locally.

Odoo task (if applicable)

https://gestion.coopiteasy.be/web#view_type=form&model=project.task&id=13567&active_id=13567&menu_id=

Checklist before approval

  • Tests are present (or not needed).
  • Credits/copyright have been changed correctly.
  • Change log snippet is present.
  • (If a new module) Moving this to OCA has been considered.

This will set the correct description on the line based on supplierinfo product_name. Otherwise the product template name is used.
@victor-champonnois victor-champonnois changed the title [FIX] run onchange_product_id() at PO line creation [FIX] set PO line name with onchange_product_id Feb 24, 2025
@huguesdk
Copy link
Member

huguesdk commented Mar 2, 2025

/ocabot merge minor

@github-grap-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-539-by-huguesdk-bump-minor, awaiting test results.

@github-grap-bot github-grap-bot merged commit 4d7ba89 into 12.0 Mar 2, 2025
3 of 4 checks passed
@github-grap-bot
Copy link
Contributor

Congratulations, your PR was merged at f5f39a3. Thanks a lot for contributing to beescoop. ❤️

@github-grap-bot github-grap-bot deleted the 12.0-fix-purchase_order_generator_supplierinfo branch March 2, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants