Fix index require path :(

Also add unit test to make sure I don't screw up like this again.

Author: Ben Demboski

index.js

@@ -1,4 +1,4 @@
-const createHandler = require('./lib/create-handler');
+const createHandler = require('./lib/handler');
 
 function requiredParam(param, errorMessage) {
   if (!param) {

lib/handler.js

@@ -22,7 +22,7 @@ module.exports = function createHandler({
 
     if (host !== endpoint) {
       callback({ error: `Unrecognized ${name}:// endpoint: '${host}'` });
-      
+
       return;
     }
 

package.json

@@ -18,5 +18,7 @@
     "mocha": "^3.2.0",
     "sinon": "^1.17.7"
   },
-  "dependencies": {}
+  "dependencies": {
+    "mock-require": "^2.0.1"
+  }
 }

tests/unit/index-test.js

@@ -0,0 +1,91 @@
+const { assert } = require('chai');
+const mock = require('mock-require');
+const { join } = require('path');
+
+describe('handler', () => {
+  let app;
+  let protocol;
+  let onAppReady;
+  let protocolName;
+  let handlerOptions;
+
+  function register(options) {
+    require('../..')(Object.assign({
+      cwd: '.',
+      app,
+      protocol,
+    }, options));
+  }
+
+  before(() => {
+    mock('../../lib/handler', options => handlerOptions = options);
+  });
+
+  after(() => {
+    mock.stop('../../lib/handler');
+  });
+
+  beforeEach(() => {
+    app = {
+      on(evt, cb) {
+        if (evt === 'ready') {
+          onAppReady = cb;
+        }
+      },
+    };
+
+    protocol = {
+      registerFileProtocol(name/*, handler, errorHandler*/) {
+        protocolName = name;
+      },
+    };
+  });
+
+  it('works', () => {
+    register();
+    assert.ok(onAppReady);
+    onAppReady();
+
+    assert.equal(protocolName, 'serve');
+    assert.deepEqual(handlerOptions, {
+      cwd: '.',
+      name: 'serve',
+      endpoint: 'dist',
+      directoryIndexFile: 'index.html',
+      indexPath: undefined,
+    });
+  });
+
+  it('works with non-default arguments', () => {
+    register({
+      cwd: join('my', 'old'),
+      name: 'friend',
+      endpoint: 'so',
+      directoryIndexFile: 'we.html',
+      indexPath: join('meet', 'again'),
+    });
+    assert.ok(onAppReady);
+    onAppReady();
+
+    assert.equal(protocolName, 'friend');
+    assert.deepEqual(handlerOptions, {
+      cwd: join('my', 'old'),
+      name: 'friend',
+      endpoint: 'so',
+      directoryIndexFile: 'we.html',
+      indexPath: join('meet', 'again'),
+    });
+  });
+
+  it('required a cwd', () => {
+    assert.throws(() => register({ cwd: undefined }));
+  });
+
+  it('required an app', () => {
+    assert.throws(() => register({ app: undefined }));
+  });
+
+  it('required a protocol', () => {
+    assert.throws(() => register({ protocol: undefined }));
+  });
+});

yarn.lock

@@ -94,6 +94,12 @@ buffer-shims@^1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/buffer-shims/-/buffer-shims-1.0.0.tgz#9978ce317388c649ad8793028c3477ef044a8b51"
 
+caller-id@^0.1.0:
+  version "0.1.0"
+  resolved "https://registry.yarnpkg.com/caller-id/-/caller-id-0.1.0.tgz#59bdac0893d12c3871408279231f97458364f07b"
+  dependencies:
+    stack-trace "~0.0.7"
+
 caller-path@^0.1.0:
   version "0.1.0"
   resolved "https://registry.yarnpkg.com/caller-path/-/caller-path-0.1.0.tgz#94085ef63581ecd3daa92444a8fe94e82577751f"
@@ -685,6 +691,12 @@ mocha@^3.2.0:
     mkdirp "0.5.1"
     supports-color "3.1.2"
 
+mock-require@^2.0.1:
+  version "2.0.1"
+  resolved "https://registry.yarnpkg.com/mock-require/-/mock-require-2.0.1.tgz#7b0ebc79b8af5dfb1e9caefeb977804e71d2e004"
+  dependencies:
+    caller-id "^0.1.0"
+
 ms@0.7.1:
   version "0.7.1"
   resolved "https://registry.yarnpkg.com/ms/-/ms-0.7.1.tgz#9cd13c03adbff25b65effde7ce864ee952017098"
@@ -871,6 +883,10 @@ sprintf-js@~1.0.2:
   version "1.0.3"
   resolved "https://registry.yarnpkg.com/sprintf-js/-/sprintf-js-1.0.3.tgz#04e6926f662895354f3dd015203633b857297e2c"
 
+stack-trace@~0.0.7:
+  version "0.0.9"
+  resolved "https://registry.yarnpkg.com/stack-trace/-/stack-trace-0.0.9.tgz#a8f6eaeca90674c333e7c43953f275b451510695"
+
 string-width@^1.0.1:
   version "1.0.2"
   resolved "https://registry.yarnpkg.com/string-width/-/string-width-1.0.2.tgz#118bdf5b8cdc51a2a7e70d211e07e2b0b9b107d3"