Skip to content

Commit afe4f3c

Browse files
authored
Merge pull request #56 from bendemboski/v2-addon
Convert to v2 addon
2 parents a1311c6 + 470c9ab commit afe4f3c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

73 files changed

+1713
-517
lines changed

.eslintcache

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[{"/Users/ben/projects/ember-add-listener-helper/.eslintrc.js":"1","/Users/ben/projects/ember-add-listener-helper/.prettierrc.js":"2","/Users/ben/projects/ember-add-listener-helper/.stylelintrc.js":"3","/Users/ben/projects/ember-add-listener-helper/.template-lintrc.js":"4","/Users/ben/projects/ember-add-listener-helper/addon/helpers/add-listener.js":"5","/Users/ben/projects/ember-add-listener-helper/app/helpers/add-listener.js":"6","/Users/ben/projects/ember-add-listener-helper/ember-cli-build.js":"7","/Users/ben/projects/ember-add-listener-helper/index.js":"8","/Users/ben/projects/ember-add-listener-helper/testem.js":"9","/Users/ben/projects/ember-add-listener-helper/tests/dummy/app/app.js":"10","/Users/ben/projects/ember-add-listener-helper/tests/dummy/app/router.js":"11","/Users/ben/projects/ember-add-listener-helper/tests/dummy/config/ember-try.js":"12","/Users/ben/projects/ember-add-listener-helper/tests/dummy/config/environment.js":"13","/Users/ben/projects/ember-add-listener-helper/tests/dummy/config/targets.js":"14","/Users/ben/projects/ember-add-listener-helper/tests/helpers/index.js":"15","/Users/ben/projects/ember-add-listener-helper/tests/integration/helpers/add-listener-test.js":"16","/Users/ben/projects/ember-add-listener-helper/tests/test-helper.js":"17"},{"size":1165,"mtime":1690064495124,"results":"18","hashOfConfig":"19"},{"size":149,"mtime":1690064495125,"results":"20","hashOfConfig":"19"},{"size":113,"mtime":1690064495125,"results":"21","hashOfConfig":"19"},{"size":63,"mtime":1632241774614,"results":"22","hashOfConfig":"19"},{"size":650,"mtime":1632241774616,"results":"23","hashOfConfig":"19"},{"size":74,"mtime":1632242376815,"results":"24","hashOfConfig":"19"},{"size":641,"mtime":1690064495126,"results":"25","hashOfConfig":"19"},{"size":72,"mtime":1632241774618,"results":"26","hashOfConfig":"19"},{"size":589,"mtime":1632241774619,"results":"27","hashOfConfig":"19"},{"size":388,"mtime":1632241774620,"results":"28","hashOfConfig":"19"},{"size":240,"mtime":1632241774620,"results":"29","hashOfConfig":"19"},{"size":1133,"mtime":1690064495127,"results":"30","hashOfConfig":"19"},{"size":1164,"mtime":1690064495127,"results":"31","hashOfConfig":"19"},{"size":157,"mtime":1690064495127,"results":"32","hashOfConfig":"19"},{"size":1269,"mtime":1690064495128,"results":"33","hashOfConfig":"19"},{"size":4267,"mtime":1690064548652,"results":"34","hashOfConfig":"19"},{"size":323,"mtime":1632241774623,"results":"35","hashOfConfig":"19"},{"filePath":"36","messages":"37","suppressedMessages":"38","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"12fwwhn",{"filePath":"39","messages":"40","suppressedMessages":"41","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"42","messages":"43","suppressedMessages":"44","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"45","messages":"46","suppressedMessages":"47","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"48","messages":"49","suppressedMessages":"50","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"51","messages":"52","suppressedMessages":"53","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"54","messages":"55","suppressedMessages":"56","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"57","messages":"58","suppressedMessages":"59","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"60","messages":"61","suppressedMessages":"62","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"63","messages":"64","suppressedMessages":"65","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"66","messages":"67","suppressedMessages":"68","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"69","messages":"70","suppressedMessages":"71","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"72","messages":"73","suppressedMessages":"74","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"75","messages":"76","suppressedMessages":"77","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"78","messages":"79","suppressedMessages":"80","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"81","messages":"82","suppressedMessages":"83","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"84","messages":"85","suppressedMessages":"86","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/ben/projects/ember-add-listener-helper/.eslintrc.js",[],[],"/Users/ben/projects/ember-add-listener-helper/.prettierrc.js",[],[],"/Users/ben/projects/ember-add-listener-helper/.stylelintrc.js",[],[],"/Users/ben/projects/ember-add-listener-helper/.template-lintrc.js",[],[],"/Users/ben/projects/ember-add-listener-helper/addon/helpers/add-listener.js",[],[],"/Users/ben/projects/ember-add-listener-helper/app/helpers/add-listener.js",[],[],"/Users/ben/projects/ember-add-listener-helper/ember-cli-build.js",[],[],"/Users/ben/projects/ember-add-listener-helper/index.js",[],[],"/Users/ben/projects/ember-add-listener-helper/testem.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/dummy/app/app.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/dummy/app/router.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/dummy/config/ember-try.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/dummy/config/environment.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/dummy/config/targets.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/helpers/index.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/integration/helpers/add-listener-test.js",[],[],"/Users/ben/projects/ember-add-listener-helper/tests/test-helper.js",[],[]]

.github/workflows/ci.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ jobs:
3030
run: yarn lint
3131
- name: Run Tests
3232
run: yarn test:ember
33+
working-directory: ./test-app
3334

3435
floating:
3536
name: "Floating Dependencies"
@@ -46,6 +47,7 @@ jobs:
4647
run: yarn install --no-lockfile
4748
- name: Run Tests
4849
run: yarn test:ember
50+
working-directory: ./test-app
4951

5052
try-scenarios:
5153
name: ${{ matrix.try-scenario }}
@@ -57,7 +59,6 @@ jobs:
5759
fail-fast: false
5860
matrix:
5961
try-scenario:
60-
- ember-lts-4.4
6162
- ember-lts-4.8
6263
- ember-release
6364
- ember-beta
@@ -76,3 +77,4 @@ jobs:
7677
run: yarn install --frozen-lockfile
7778
- name: Run Tests
7879
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
80+
working-directory: ./test-app

.gitignore

+13-8
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,29 @@
1+
# See https://help.github.com/ignore-files/ for more about ignoring files.
2+
13
# compiled output
2-
/dist/
4+
dist/
5+
declarations/
6+
7+
# npm/pnpm/yarn pack output
8+
*.tgz
39

410
# dependencies
5-
/node_modules/
11+
node_modules/
612

713
# misc
814
/.env*
915
/.pnp*
10-
/.eslintcache
16+
/.pnpm-debug.log
17+
/.sass-cache
18+
.eslintcache
19+
/connect.lock
1120
/coverage/
21+
/libpeerconnection.log
1222
/npm-debug.log*
1323
/testem.log
1424
/yarn-error.log
1525

1626
# ember-try
1727
/.node_modules.ember-try/
18-
/npm-shrinkwrap.json.ember-try
1928
/package.json.ember-try
20-
/package-lock.json.ember-try
2129
/yarn.lock.ember-try
22-
23-
# broccoli-debug
24-
/DEBUG/

.npmignore

-35
This file was deleted.

.prettierrc.js

+1-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
overrides: [
5-
{
6-
files: '*.{js,ts}',
7-
options: {
8-
singleQuote: true,
9-
},
10-
},
11-
],
4+
singleQuote: true,
125
};

CONTRIBUTING.md

+17-11
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,30 @@
22

33
## Installation
44

5-
* `git clone <repository-url>`
6-
* `cd ember-add-listener-helper`
7-
* `yarn install`
5+
- `git clone <repository-url>`
6+
- `cd ember-add-listener-helper`
7+
- `yarn install`
88

99
## Linting
1010

11-
* `yarn lint`
12-
* `yarn lint:fix`
11+
- `yarn lint`
12+
- `yarn lint:fix`
13+
14+
## Building the addon
15+
16+
- `cd ember-add-listener-helper`
17+
- `yarn build`
1318

1419
## Running tests
1520

16-
* `ember test` – Runs the test suite on the current Ember version
17-
* `ember test --server` – Runs the test suite in "watch mode"
18-
* `ember try:each` – Runs the test suite against multiple Ember versions
21+
- `cd test-app`
22+
- `yarn test` – Runs the test suite on the current Ember version
23+
- `yarn test:watch` – Runs the test suite in "watch mode"
1924

20-
## Running the dummy application
25+
## Running the test application
2126

22-
* `ember serve`
23-
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
27+
- `cd test-app`
28+
- `yarn start`
29+
- Visit the test application at [http://localhost:4200](http://localhost:4200).
2430

2531
For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).

LICENSE.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
The MIT License (MIT)
22

3-
Copyright (c) 2019
3+
Copyright (c) 2023
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
66

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ Easily and safely use `@ember/object/events` via a template helper
99

1010
## Compatibility
1111

12-
* Ember.js v4.4 or above
13-
* Ember CLI v4.4 or above
12+
* Ember.js v4.8 or above
13+
* Ember CLI v4.8 or above
1414
* Node.js v16 or above
1515

1616

addon/helpers/add-listener.js

-27
This file was deleted.

app/helpers/add-listener.js

-1
This file was deleted.
+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
[{"/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/src/helpers/add-listener.js":"1","/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/.eslintrc.cjs":"2","/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/addon-main.cjs":"3","/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/unpublished-development-types/index.d.ts":"4"},{"size":650,"mtime":1632241774616,"results":"5","hashOfConfig":"6"},{"size":950,"mtime":1690067013366,"results":"7","hashOfConfig":"6"},{"size":114,"mtime":1690067288093,"results":"8","hashOfConfig":"6"},{"size":670,"mtime":1690068628088,"results":"9","hashOfConfig":"6"},{"filePath":"10","messages":"11","suppressedMessages":"12","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"da3osg",{"filePath":"13","messages":"14","suppressedMessages":"15","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"16","messages":"17","suppressedMessages":"18","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"19","messages":"20","suppressedMessages":"21","errorCount":0,"fatalErrorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/src/helpers/add-listener.js",[],[],"/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/.eslintrc.cjs",[],[],"/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/addon-main.cjs",[],[],"/Users/ben/projects/ember-add-listener-helper/ember-add-listener-helper/unpublished-development-types/index.d.ts",[],["22"],{"ruleId":"23","severity":2,"message":"24","line":10,"column":28,"nodeType":"25","messageId":"26","endLine":10,"endColumn":36,"suppressions":"27"},"@typescript-eslint/no-empty-interface","An empty interface is equivalent to `{}`.","Identifier","noEmpty",["28"],{"kind":"29","justification":"30"},"directive",""]

.eslintignore ember-add-listener-helper/.eslintignore

+1-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@
33

44
# compiled output
55
/dist/
6+
/declarations/
67

78
# misc
89
/coverage/
9-
!.*
10-
.*/
11-
12-
# ember-try
13-
/.node_modules.ember-try/
+50
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,50 @@
1+
'use strict';
2+
3+
module.exports = {
4+
root: true,
5+
parser: '@typescript-eslint/parser',
6+
parserOptions: {
7+
ecmaVersion: 'latest',
8+
},
9+
plugins: ['ember'],
10+
extends: [
11+
'eslint:recommended',
12+
'plugin:ember/recommended',
13+
'plugin:prettier/recommended',
14+
],
15+
env: {
16+
browser: true,
17+
},
18+
rules: {},
19+
overrides: [
20+
// ts files
21+
{
22+
files: ['**/*.ts'],
23+
extends: [
24+
'plugin:@typescript-eslint/eslint-recommended',
25+
'plugin:@typescript-eslint/recommended',
26+
],
27+
rules: {
28+
// Add any custom rules here
29+
},
30+
},
31+
// node files
32+
{
33+
files: [
34+
'./.eslintrc.cjs',
35+
'./.prettierrc.js',
36+
'./.template-lintrc.cjs',
37+
'./addon-main.cjs',
38+
],
39+
parserOptions: {
40+
sourceType: 'script',
41+
},
42+
env: {
43+
browser: false,
44+
node: true,
45+
},
46+
plugins: ['n'],
47+
extends: ['plugin:n/recommended'],
48+
},
49+
],
50+
};

ember-add-listener-helper/.gitignore

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# The authoritative copies of these live in the monorepo root (because they're
2+
# more useful on github that way), but the build copies them into here so they
3+
# will also appear in published NPM packages.
4+
/README.md
5+
/LICENSE.md

.prettierignore ember-add-listener-helper/.prettierignore

+1-5
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,7 @@
33

44
# compiled output
55
/dist/
6+
/declarations/
67

78
# misc
89
/coverage/
9-
!.*
10-
.*/
11-
12-
# ember-try
13-
/.node_modules.ember-try/
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
name: require('./package').name,
4+
singleQuote: true,
55
};
File renamed without changes.
File renamed without changes.
File renamed without changes.
+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
'use strict';
2+
3+
const { addonV1Shim } = require('@embroider/addon-shim');
4+
module.exports = addonV1Shim(__dirname);
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"presets": [["@babel/preset-typescript"]],
3+
"plugins": [
4+
"@embroider/addon-dev/template-colocation-plugin",
5+
["@babel/plugin-transform-typescript", { "allowDeclareFields": true }],
6+
["@babel/plugin-proposal-decorators", { "version": "legacy" }],
7+
"@babel/plugin-proposal-class-properties"
8+
]
9+
}

0 commit comments

Comments
 (0)