Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge this functionality upstream? #36

Open
paulmelnikow opened this issue Jul 3, 2019 · 1 comment
Open

Merge this functionality upstream? #36

paulmelnikow opened this issue Jul 3, 2019 · 1 comment

Comments

@paulmelnikow
Copy link
Collaborator

The more I work on this, the more I wonder: should the Promises API be merged into node-tmp?

Promises are so common these days that I'm not sure I see the benefit of shipping a version of node-tmp without elegant promise support. If users don't want the promises of course they don't have to use them.

The interface could be similar to Node's fs:

const { promises: tmp } = require('tmp')

await tmp.file()

If the parties agree I'd be happy to do the lifting!

/cc @silkentrance @raszi

@benjamingr
Copy link
Owner

I am for it. I would prefer not to maintain this package - I am doing it as a service for the community and while it is not a lot of work not maintaining it is even less work :)

As a side note - we have promise APIs for most APIs in Node now and the gaps are closing.

I think this would make sense. The status quo isn't bad but callbacks should be the second class citizen going forward most likely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants