Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest node-tmp #42

Merged
merged 1 commit into from
Apr 26, 2020
Merged

Upgrade to latest node-tmp #42

merged 1 commit into from
Apr 26, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Apr 26, 2020

This upgrades tmp-promise to latest node-tmp@0.2.0.

I checked the breaking changes from that version, and no changes in tmp-promise should be required.

I have also submitted a PR (DefinitelyTyped/DefinitelyTyped#44241) to upgrade the TypeScript types. When this is merged, I will upgrade them to 0.2.0.

I am also adding ^ so that new patch versions of node-tmp do not require updates from tmp-promise.

@benjamingr
Copy link
Owner

Thanks a lot :]

@benjamingr benjamingr merged commit 2a005eb into benjamingr:master Apr 26, 2020
@benjamingr
Copy link
Owner

How soon do you need a release? Is it OK if I test this for a day or two first or is this blocking something in your workflow?

@ehmicky
Copy link
Contributor Author

ehmicky commented Apr 26, 2020

No, there is nothing urgent for me.

Please note that the TypeScript types should be upgraded to 0.2.0 once DefinitelyTyped/DefinitelyTyped#44241 is merged. Although the types are the same, only the version is changing. I commented on node-tmp to hopefully get the types merging in to node-tmp itself.

@ehmicky ehmicky deleted the feat/upgrade-node-tmp branch April 26, 2020 17:47
@ehmicky
Copy link
Contributor Author

ehmicky commented May 3, 2020

Would this be ready for a release?

@benjamingr
Copy link
Owner

Would this be ready for a release?

Hey, it worked fine locally and tests pass, I'll publish

@benjamingr
Copy link
Owner

Published tmp-promise@2.1.0 - thank you for your contribution :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants