adress review comments

README.md

@@ -51,6 +51,8 @@ import {
 import YourSessionWorker as SessionWorker from "../session.worker"
 import { AUTH_CALLBACK_URL, BENTO_URL_NO_TRAILING_SLASH, CLIENT_ID, OPENID_CONFIG_URL } from "../config";
 
+// Session worker creator function must be in a constant for useSessionWorkerTokenRefresh
+const createSessionWorker = () => new SessionWorker();
 
 const App = () => {
     const dispatch = useDispatch();
@@ -87,7 +89,7 @@ const App = () => {
     useSessionWorkerTokenRefresh(
         CLIENT_ID,
         sessionWorker,
-        () => new SessionWorker(),
+        createSessionWorker, 
         fetchUserDependentData(nop),
     );
 

src/hooks.ts

@@ -48,7 +48,7 @@ export const useOpenIdConfig = (openIdConfigUrl: string) => {
 
     useEffect(() => {
         dispatch(fetchOpenIdConfiguration(openIdConfigUrl));
-    }, [dispatch]);
+    }, [dispatch, openIdConfigUrl]);
 
     return useSelector((state: RootState) => state.openIdConfiguration.data);
 }
@@ -92,7 +92,13 @@ export const useSessionWorkerTokenRefresh = (
             });
             sessionWorkerRef.current = sw;
         }
-    }, [dispatch]);
+
+        return () => {
+            if (sessionWorkerRef.current) {
+                sessionWorkerRef.current.terminate();
+            }
+        }
+    }, [dispatch, createWorker, fetchUserDependentData]);
 };
 
 interface OpenIdConfig {
@@ -126,7 +132,7 @@ export const useOpenSignInWindowCallback = (
                 `${windowFeatures}, top=${popupTop}, left=${popupLeft}`,
             );
         })();
-    }, [openIdConfig]);
+    }, [openIdConfig, clientId, authCallbackUrl, windowFeatures]);
 };
 
 export const usePopupOpenerAuthCallback = (applicationUrl: string) => {

src/performAuth.ts

@@ -146,5 +146,3 @@ export const checkIsInAuthPopup = (applicationUrl: string): boolean => {
         return false;
     }
 }
-
-