Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't execute invalid refresh token attempts #37

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

davidlougheed
Copy link
Member

before this change, refresh token dispatches with an empty refresh token field will actually query the IdP. They shouldn't be executed at all, and the action should not be dispatched if we know there's no refresh token present - addressed in this PR.

before this change, refresh token dispatches with an empty refresh token field
will actually query the IdP. They shouldn't be executed at all, and the action should
not be dispatched if we know there's no refresh token present - addressed in this PR.
@davidlougheed davidlougheed changed the title fix: don't execute invalid refresh token attempts Don't execute invalid refresh token attempts Sep 12, 2024
Copy link
Contributor

@v-rocheleau v-rocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@davidlougheed davidlougheed merged commit aa754c3 into main Sep 13, 2024
2 checks passed
@davidlougheed davidlougheed deleted the fix/refresh-tokens-spam branch September 13, 2024 14:04
Copy link

🎉 This issue has been resolved in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants