Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error + hasAttempted props to useHasResourcePermission #41

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

davidlougheed
Copy link
Member

No description provided.

@davidlougheed davidlougheed requested a review from gsfk February 14, 2025 15:41
@davidlougheed
Copy link
Member Author

@gsfk just asking for basic sanity check here, not testing directly.

@davidlougheed davidlougheed force-pushed the feat/complete-has-resource-permission branch from cc6105c to 68f8838 Compare February 14, 2025 20:29
Copy link
Member

@gsfk gsfk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used this library at all, so hard even to sanity check.

Looks fine, although for hasAttempted it's not clear to me what's been attempted. But that might be because I've never used this code.

@davidlougheed
Copy link
Member Author

the request is what gets attempted here - hasAttempted indicates basically that it succeeded or failed (but at least has been tried.) perhaps not the best structure for this; elsewhere in bento public we've moved to an enum state for this type of thing instead.

@davidlougheed davidlougheed merged commit 52b875c into main Feb 14, 2025
2 checks passed
@davidlougheed davidlougheed deleted the feat/complete-has-resource-permission branch February 14, 2025 21:18
Copy link

🎉 This PR is included in version 7.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants