Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon: remove form rules for assembly ID #143

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Jan 10, 2024

Remove blank "rules" array for assembly ID in variants search form (Redmine #2010):

  • it's not needed, since there are no rules to apply (probably the form was originally built using a map() call, so it was put there for consistency with the other fields)
  • having rules here breaks the form when the assembly ID field is empty (which can happen if more than one assembly is present): antd tries and fails to apply the rules to a blank field, even though there are no rules to apply. Since the way to search metadata only is to leave the variants form blank, blank fields need to be handled correctly.

@gsfk gsfk merged commit 5a6cd4f into main Jan 11, 2024
2 checks passed
@davidlougheed davidlougheed deleted the fixes/beacon-form-assembly-id branch February 8, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants