beacon: use a different overview endpoint #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidlougheed
approved these changes
Jan 11, 2024
| @@ -7,7 +7,7 @@ import { printAPIError } from '@/utils/error.util'; | |||
| export const getBeaconConfig = createAsyncThunk<BeaconConfigResponse, void, { state: RootState; rejectValue: string }>( | |||
| 'beaconConfig/getBeaconConfig', | |||
| (_, { getState, rejectWithValue }) => { | |||
| const beaconInfoEndpoint = getState()?.config?.beaconUrl + '/info'; | |||
| const beaconInfoEndpoint = getState()?.config?.beaconUrl + '/overview'; | |||
There was a problem hiding this comment.
we should probably reject this if beaconUrl is undefined, but since the behaviour is already like this, this PR is good to merge
There was a problem hiding this comment.
The UI isn't rendered until beaconUrl is defined, so it would be hard to get into this state.
There was a problem hiding this comment.
it's more that having the question marks sort of implies that it can somehow
also it's unneeded to have a ? after getState() and config I think anyway, since getState.config should always return an object...
There was a problem hiding this comment.
This was probably a code copying crime on my part, removing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change beacon overview endpoint to
/overview(Redmine #1859)