-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nav scope title + breadcrumbs #248
Conversation
requesting an initial pass - i know lint is failing right now |
Works okay, no major issues on my end. I like the sticky part.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that it does address the major issues with navigation in public. Something about it ui wise feels a lil off but that is just me. I am satisfied with it that I would be happy with it being a part of public. (Haven't yet looked at the code).
Couldn't find any behavioral bugs with it for now. Also, it would be great to have cta buttons for overview and search in provenance of projects.
what do you mean by "Also, it would be great to have cta buttons for overview and search in provenance of projects."? sorry, a little confused there and let me know if you figure out what bugs you about the UI stuff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass.
Somethings felt like they could be split up into different PRs. Don't hesitate to make different PRs for separation of concerns, as it doe help in better and faster reviews.(And also increases the rate at which new code is adopted).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
No description provided.