Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull search options from beacon #256

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

gsfk
Copy link
Member

@gsfk gsfk commented Feb 27, 2025

Previously, the beacon tab in bento public has used the same discovery config settings as the Search tab to set metadata search options. Since Bento 18, beacon now knows its own search options, so these can be pulled from the beacon endpoint /filtering_terms instead.

  • makes Beacon more self-contained and closer to its intended use:
    • it's now beacon's job to call katsu to figure out what the search options are, rather than leaving this to the web client
    • leaves open the possibility of filters that apply to other services (eg Takuan)
    • ideally the beacon UI should only need to communicate with beacon
  • leaves open the possibility of working with non-Bento beacons

... and in general relying more on beacon /filtering_terms instead of direct calls to katsu will simplify the operation of the beacon network.

Also:

  • made beacon config call conditional (it should have always been conditional)
  • remapped some fields in beacon network filters (since they still follow "querySections" syntax)

@gsfk gsfk requested a review from SanjeevLakhwani February 27, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant