remove unnecessary possibleType field on edge

benweint · Jun 4, 2024 · 563fb04 · 563fb04
1 parent a119b1d
commit 563fb04
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/pkg/graph/edge.go b/pkg/graph/edge.go
@@ -11,10 +11,9 @@ const (
 )
 
 type edge struct {
-	src          *model.Definition
-	dst          *model.Definition
-	kind         edgeKind
-	field        *model.FieldDefinition
-	argument     *model.ArgumentDefinition
-	possibleType string
+	kind     edgeKind
+	src      *model.Definition
+	dst      *model.Definition
+	field    *model.FieldDefinition    // only set for fields representing eges or arguments
+	argument *model.ArgumentDefinition // only set for fields representing arguments
 }
diff --git a/pkg/graph/graph.go b/pkg/graph/graph.go
@@ -94,10 +94,9 @@ func (g *Graph) makeUnionEdges(t *model.Definition) []*edge {
 			continue
 		}
 		result = append(result, &edge{
-			src:          srcNode,
-			dst:          dstNode,
-			kind:         edgeKindPossibleType,
-			possibleType: possibleType,
+			src:  srcNode,
+			dst:  dstNode,
+			kind: edgeKindPossibleType,
 		})
 	}
 	return result
@@ -269,7 +268,7 @@ func (g *Graph) buildEdgeDefs() []string {
 			case edgeKindArgument:
 				srcPortSuffix = ":" + portNameForArgument(edge.field.Name, edge.argument.Name)
 			case edgeKindPossibleType:
-				srcPortSuffix = ":" + portName(edge.possibleType)
+				srcPortSuffix = ":" + portName(edge.dst.Name)
 			}
 
 			result = append(result, fmt.Sprintf("  %s%s -> %s%s", nodeID(edge.src), srcPortSuffix, nodeID(edge.dst), dstPortSuffix))