fix #153 (JDK 21+ compatibility) #154
Conversation
This reverts commit ff23253.
|
Ah this is why it wasn't working with 21. Why no merge yet after 3 months? |
|
@PerryCameron I think the original maintainer, @siordache, simply does not have time to regularly update the project anymore. He asked for co-maintainers a while ago and someone stepped up, but it seems that person also has abandoned the project. I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again). I didn't step up as a co-maintainer back then because this project is mainly Groovy and I am really a noob in that language, but maybe I should have. In the meantime, I have volunteered to become a co-maintainer, but @siordache did not reply yet. |
That sounds very promising 👍, Thanks! |
|
Thank you! Not yet. It's on my list. I will post here when it's done. |
|
@danielpeintner I have released a patched version of the plugin to plugin central. To use it, change the plugin id in your gradle build script fom Please report back if something doesn't work. And if it's of interest to anyone, I have done the same for the sister-plugin Badass-Jlink-Plugin. Sources for my patched version of the plugin: https://github.com/xzel23/badass-runtime-plugin |
Thank you a lot! It worked nicely 👍. |
Updates the runtime plugin to a fork with support for java 21, instead of the upstream https://github.com/beryx/badass-runtime-plugin. See beryx/badass-runtime-plugin#154 for more details. Also changed the java version back to 21.
* add runtime plugin for generating stand-alone images * add JReleaser configuration for github release and runtimes * Use runtime plugin fork Updates the runtime plugin to a fork with support for java 21, instead of the upstream https://github.com/beryx/badass-runtime-plugin. See beryx/badass-runtime-plugin#154 for more details. Also changed the java version back to 21. * Remove deploy github workflow We had a github workflow that would run on a tag push, creating a new release and uploading a zip of the language server. Jreleaser should take care of all that now, so the workflow is unnecessary. * Add changelog to github release notes So we don't have to manually add the release notes to the github release after it is published. I added a custom task to read in the full changelog, and parse out the entry for the latest version. The result is written out to a resources file that I pointed the github release config to. The jreleaser docs don't seem to be 100% clear on whether the changelog is actually what ends up in the release notes, but it would make sense to me, and the text in https://jreleaser.org/guide/latest/reference/release/github.html#_release_notes suggests it. --------- Co-authored-by: Miles Ziemer <mziemer@amazon.com>
This PR fixes #153: