Skip to content

Commit 95b80a1

Browse files
authored
Merge pull request #300 from bigcommerce/php84
chore(platform): PHPMNT-177 Add PHP 8.4 to CircleCI matrix
2 parents 21d51c9 + 2510a4e commit 95b80a1

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs_default: &jobs_default
1212
php-version: << matrix.php-version >>
1313
matrix:
1414
parameters:
15-
php-version: [ *php_min, "8.2", "8.3" ]
15+
php-version: [ *php_min, "8.2", "8.3" , "8.4" ]
1616

1717
jobs:
1818
cs-fixer:

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
},
2525
"require-dev": {
2626
"friendsofphp/php-cs-fixer": "^3.13",
27-
"php-coveralls/php-coveralls": "2.5",
27+
"php-coveralls/php-coveralls": "^2.7",
2828
"phpunit/phpunit": "^10.0",
29-
"phpstan/phpstan": "^1.10",
30-
"rector/rector": "^0.19.0"
29+
"phpstan/phpstan": "^2.0",
30+
"rector/rector": "^2.0"
3131
},
3232
"autoload": {
3333
"psr-0": {

src/Bigcommerce/Api/Client.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ public static function getConnection()
269269
* @param Connection|null $connection The connection to use
270270
* @return void
271271
*/
272-
public static function setConnection(Connection $connection = null)
272+
public static function setConnection(?Connection $connection = null)
273273
{
274274
self::$connection = $connection;
275275
}

src/Bigcommerce/Api/Connection.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class Connection
2828
private $curl;
2929

3030
/**
31-
* @var array<string, string> Hash of HTTP request headers.
31+
* @var array<int, string> Hash of HTTP request headers.
3232
*/
3333
private $headers = [];
3434

@@ -258,7 +258,7 @@ public function removeHeader($header)
258258
/**
259259
* Return the request headers
260260
*
261-
* @return array<string, string>
261+
* @return array<int, string>
262262
*/
263263
public function getRequestHeaders()
264264
{

0 commit comments

Comments
 (0)