Merge pull request #209 from MaxGenash/update-eslint-on-2.x

Update ESLint, drop gulp, add package-lock.json to .gitignore (branch 2.x)

Author: junedkazi

.eslintrc

@@ -1,16 +1,14 @@
 {
   "parserOptions": {
-    "ecmaVersion": 6,
-    "sourceType": "module"
-  },
-  "ecmaFeatures": {
-    "modules": true
+    "ecmaVersion": 2018, // suppport syntax features (like Object spread operator) up to es2018
+    "sourceType": "module",
+    "ecmaFeatures": {
+      "impliedStrict": true
+    }
   },
   "env": {
-    "node": true
-  },
-  "globals": {
-
+    "node": true,
+    "es2017": true // suppport globals (like Promise) up to es2017 (es2018 doesn't have new globals)
   },
   "rules": {
     "curly": 2,

.gitignore

@@ -1 +1,3 @@
 node_modules
+.idea
+package-lock.json

.travis.yml

@@ -6,5 +6,5 @@ node_js:
 script:
   - npm install
   - npm install -g gulp-cli
-  - gulp
+  - npm run lint
   - npm test

gulpfile.js

@@ -6,6 +6,8 @@
   "author": "Bigcommerce",
   "license": "BSD-4-Clause",
   "scripts": {
+    "lint": "eslint .",
+    "lint-and-fix": "eslint . --fix",
     "test": "lab -l -t 90"
   },
   "repository": {
@@ -34,11 +36,8 @@
   },
   "devDependencies": {
     "code": "^1.4.0",
-    "eslint": "^2.7.0",
+    "eslint": "^6.8.0",
     "eslint-config-airbnb": "^6.2.0",
-    "eslint-plugin-react": "^4.3.0",
-    "gulp": "^3.9.1",
-    "gulp-eslint": "^2.0.0",
     "lab": "^13.0.1",
     "sinon": "^1.17.2"
   }

package.json

@@ -14,8 +14,8 @@ describe('pluck helper', function() {
 
     var context = {
         users: [
-          { 'user': 'barney', 'age': 36 },
-          { 'user': 'fred',   'age': 40 }
+            { 'user': 'barney', 'age': 36 },
+            { 'user': 'fred',   'age': 40 }
         ]
     };