Refactor source to be in different modules #195
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194 (WIP).
This PR is mostly here to spark conversation about the necessity of such changes and how much they impact the project itself.
EDIT: and I also needed a reason to get familiar with the source code. 😅
Changes
There seem to be no breaking changes, as all tests pass, and the "export" structure is preserved.
Modules
Split
crank.ts
into several modules:renderer
context
events
elements
and extracted miscellaneous items into
util.ts
.context
andrenderer
are still far too large, in my opinion, so I guess I'll try to polish and split them up a bit more. Hence the "draft" status.Adapted build process to be independent from the module structure.
Build artifacts
All distributed artifacts now rest in the
dist
folder, structured by their respective format.For "cjs" and "esm" formats, the original module structure is now preserved for better tree-shaking.
Reordered some fields in
package.json
to achieve, I hope, better readability for contributors.Website and examples
are still in their original place, as I can do nothing about it. 😅